store: support close for an on prem store
Metadata
Current evaluation
Merged into main after approval and passing CI. Adds close support for on-prem stores, modifying four files and increasing test coverage by 0.02%.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
CRAFT-751
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after approval and passing CI. Adds close support for on-prem stores, modifying four files and increasing test coverage by 0.02%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main, adding close support for on-prem stores. Authored by maintainer sergiusens, the change passed all checks with 100% diff coverage and increased overall test coverage by 0.02%. Resolves CRAFT-751. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main, adding close support for on-prem stores. The change increased coverage by 0.02% with 100% diff coverage, resolving CRAFT-751. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3885 store: initial support for an onprem store | snapcraft | merged | Merged into main, adding initial onprem store support. Approved by one reviewer, passed CI, and increased coverage by 0.08%. The change modifies four files to implement the feature. | |
| #3887 store: support status for an onprem store | snapcraft | merged | Merged into main. Adds status support for on-prem stores. Approved by maintainers, passed CI checks, and achieved 100% diff coverage before integration. | |
| #3908 tests unit: add for on prem store list-revisions | snapcraft | merged | Merged into main following reviewer approval and successful CI checks. Introduces unit tests for on-prem store list-revisions, raising overall coverage by 0.07%. | |
| #3880 store: on prem base client | snapcraft | merged | Merged into main. Adds an OnPrem base client derived from craft-store to support Snapcraft's on-premise store. Approved by reviewer, passed CI, and increased unit test coverage by 0.05%. | |
| #3955 onprem store: support new credentials format | snapcraft | merged | Successfully merged changes implementing a new credentials format for the onprem store. Approved by two reviewers, passed CI checks, and modified four files with 21 additions and 8 deletions. | |
| #1280 Added support for 'branches' in Store responses (release, close, and status). | snapcraft | merged | Merged into master. Adds branch support to Store responses for release, close, and status. Improves error handling for unknown branches, removes unused code, and cleans up tests. Approved, passed CI, and achieved 100% diff coverage. |