← Back to issue list

config: add snap config model

View original Github issue

Metadata

Project
snapcraft
Number
#3893
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #3893 (snap config model, CRAFT-1321) closed unmerged by author mr-cal on 2022-08-31; superseded by #3898, which added a snaphelpers-based config model and merged as d8db11e16.

Resolution: closed superseded

Reason: mr-cal closed the PR himself, stating Charmcraft's snaphelpers-based approach was better; the replacement PR snapcore/snapcraft#3898 was merged as commit d8db11e16 ('config: add snap config model'), later used by #3903 (7cc2a529e) to pick the default provider.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Allows Snapcraft to parse data set via `snap set snapcraft <key>=<value>` Currently, the only supported parameter is `provider`, which will be used in an upcoming PR to allow users to choose a default provider. (CRAFT-1321)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #3893 (snap config model, CRAFT-1321) closed unmerged by author mr-cal on 2022-08-31; superseded by #3898, which added a snaphelpers-based config model and merged as d8db11e16.
stealth/space-bunny-alpha — closed superseded Closed unmerged; superseded by snapcore/snapcraft#3898, which added a snaphelpers-based Snap configuration model and merged as d8db11e16.
qwen/qwen3.6-35b-a3b — — Closed by author. The snap config model was abandoned and superseded by a new implementation leveraging the snaphelpers library for better configuration handling.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded. Added a snap config model to parse snap set snapcraft data, specifically the provider key. The author closed it to replace the custom implementation with the snaphelpers library in a follow-up PR.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcore/snapcraft#3898 (confidence 97%)

    Same title, snaphelpers-based reimplementation; merged as d8db11e16

  • Related To: snapcore/snapcraft#3903 (confidence 80%)

    Commit 7cc2a529e 'providers: choose legacy default provider from snap config' consumes the config model

Related issues

Issue Project State Summary Similarity
#239 feat(snap_config): add snap_config model and utilities craft-application merged Merged PR #239 as commit 21393ee7, adding generic snap_config models and utilities imported from Snapcraft for CRAFT-2477 build-mode support.
80%
#3898 config: add snap config model snapcraft merged Merged into main via snapcore/snapcraft#3898 (d8db11e16), adding a snap configuration model to parse `snap set snapcraft key=value` data.
80%