← Back to issue list

store: on prem support for list-revisions

View original Github issue

Metadata

Project
snapcraft
Number
#3901
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR snapcore/snapcraft#3901 (commit 9fb175127) ported list-revisions to the new command structure, added on-prem store support via legacy Releases class, and ignored channel data missing from Publisher Gateway replies.

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit 9fb175127 ("store: on prem support for list-revisions (#3901)"), completing the CRAFT-1312 migration. Follow-up PR #3908 (commit e625cf62) added the missing unit tests for the new on-prem list-revisions code, which the PR's codecov report showed as a slight coverage dip.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- migrate the code for list revisions from legacy into the new codebase using the new command structure - remove the legacy test code - add support for the on prem store variant using the Releases class from legacy taking into account that revisions returned by the new Publisher Gateway have no release information - consider no channel information when presenting revisions Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- CRAFT-1312

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR snapcore/snapcraft#3901 (commit 9fb175127) ported list-revisions to the new command structure, added on-prem store support via legacy Releases class, and ignored channel data missing from Publisher Gateway replies.
stealth/space-bunny-alpha — closed resolved Merged PR snapcore/snapcraft#3901 moved list-revisions to the new command structure, added on-prem Releases support, and handled missing release data while omitting channel information.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI checks. Migrates list-revisions from legacy to the new codebase, adds on-prem store support via the Releases class, and updates output to omit channel data and handle missing release information.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Migrated list-revisions to the new codebase and added on-prem store support. Adapted to handle missing release and channel data from the Publisher Gateway. Minor coverage drop noted but changes were accepted.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#3885 (confidence 88%)

    PR #3885 (commit 260214788) introduced the initial OnPremStore support that this PR extends to list-revisions.

  • Related To: snapcore/snapcraft#3908 (confidence 85%)

    Follow-up merged PR adding unit test coverage for the on-prem list-revisions code introduced here, addressing the coverage regression flagged by codecov.

  • Related To: snapcore/snapcraft#1160 (confidence 60%)

    Earlier PR that renamed the 'history' command to 'list-revisions'; this PR continues the command migration away from the legacy implementation.

Related issues

Issue Project State Summary Similarity
#3887 store: support status for an onprem store snapcraft merged Merged into main as c8e8d598a, adding status support for on-prem Snapcraft stores.
72%