← Back to issue list

store: on prem support for list-revisions

View original Github issue

Metadata

Project
snapcraft
Number
#3901
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and CI checks. Migrates list-revisions from legacy to the new codebase, adds on-prem store support via the Releases class, and updates output to omit channel data and handle missing release information.

Suggested action:

No scores available.

Issue body

- migrate the code for list revisions from legacy into the new codebase using the new command structure - remove the legacy test code - add support for the on prem store variant using the Releases class from legacy taking into account that revisions returned by the new Publisher Gateway have no release information - consider no channel information when presenting revisions Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- CRAFT-1312

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and CI checks. Migrates list-revisions from legacy to the new codebase, adds on-prem store support via the Releases class, and updates output to omit channel data and handle missing release information.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Migrated list-revisions to the new codebase and added on-prem store support. Adapted to handle missing release and channel data from the Publisher Gateway. Minor coverage drop noted but changes were accepted.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Migrated list-revisions to the new codebase, added on-prem store support, removed legacy code, and adjusted revision output to ignore channel info. Codecov reported a minor coverage decrease with 86.53% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#86 The "list revisions from the Store" command charmcraft merged Successfully merged after approval by two reviewers. The changes implement a new list revisions from the Store command across seven files, adding 350 lines and removing four to enable repository revision tracking.
74%
#3908 tests unit: add for on prem store list-revisions snapcraft merged Merged into main following reviewer approval and successful CI checks. Introduces unit tests for on-prem store list-revisions, raising overall coverage by 0.07%.
71%
#3885 store: initial support for an onprem store snapcraft merged Merged into main, adding initial onprem store support. Approved by one reviewer, passed CI, and increased coverage by 0.08%. The change modifies four files to implement the feature.
70%