cli: move remote build out of legacy
Metadata
Current evaluation
Merged into main as PR #3919. Moved CLI remote build logic out of legacy, exported --build-for, hidden --build-on, and fixed emitter stopping during prompts. Approved and passed CI checks.
Suggested action: —
No scores available.
Issue body
- move the CLI logic out of legacy
- export --build-for and hide --build-on
- stop the emitter when calling confirm_with_user's prompt
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
CRAFT-1384
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main as PR #3919. Moved CLI remote build logic out of legacy, exported --build-for, hidden --build-on, and fixed emitter stopping during prompts. Approved and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Moves remote build CLI logic out of legacy, exports --build-for, hides --build-on, and stops the emitter during confirm_with_user prompts. Resolves CRAFT-1384. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Moved remote build CLI logic out of legacy, exported --build-for, hid --build-on, and fixed emitter behavior during prompts. Resolves CRAFT-1384. Codecov noted a minor coverage decrease upon merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2798 cli: improve the remote-build upload messaging | snapcraft | merged | Merged changes improving CLI remote-build upload messaging. The update replaces public with publicly available to clarify artifact visibility. Approved by reviewer, passed CI, and integrated with minimal code changes. | |
| #3553 cli: make remote-build more user-friendly | snapcraft | merged | Merged improvements to remote-build CLI. Aligns --recover with --status, suppresses unnecessary public data prompts when checking status, and adds tests. Approved and merged. | |
| #4395 feat(remote-build): new command logic | snapcraft | merged | Merged into main. Introduces a RemoteBuild class to orchestrate remote builds, adds local project directory caching, and implements post-build cache cleanup. Resolves #4324. Approved by three reviewers with passing CI and 97.88% diff coverage. | |
| #2571 cli: refactor re-execution into legacy | snapcraft | merged | Merged CLI refactor moving re-execution into legacy mode. Introduces a custom click.Command class to detect legacy invocation and adds skeletons for remote parts, search, update, and define. Approved after manual testing and CI checks. | |
| #1546 feat: remote build command | charmcraft | merged | Merged the remote build command feature. Approved by two reviewers and passing CI, the PR rebases prior work and adds remote build functionality. Follow-up issues were created to resolve related build-id recovery and dependency bugs. | |
| #5819 fix(legacy): accept --build-for on long-form architecture remote build | snapcraft | closed | Superseded by PR #6090. This PR attempted to fix legacy remote build handling of the --build-for flag with long-form architectures. Testing revealed it still failed, so the maintainer closed it in favor of a newer fix. |