← Back to issue list

snap config: catch more errors when config cannot be retrieved

View original Github issue

Metadata

Project
snapcraft
Number
#3974
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged improvements to snap configuration error handling. Follows up on PR #3971 to catch additional retrieval failures reported by users. Approved by one reviewer, passed CI checks, and updated four files (+30/-10).

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Follow up to https://github.com/snapcore/snapcraft/pull/3971 to catch another error reported [here](https://forum.snapcraft.io/t/call-for-testing-snapcraft-7-2-0/32171/27).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged improvements to snap configuration error handling. Follows up on PR #3971 to catch additional retrieval failures reported by users. Approved by one reviewer, passed CI checks, and updated four files (+30/-10).
qwen3.6-35b-a3b-mtp-q6 Merged error handling improvements for snap configuration retrieval. The change catches additional exceptions to prevent crashes, addressing a forum-reported issue and following PR #3971.
qwen3.6-35b-a3b-mtp-q6 Merged a follow-up to PR #3971 that enhances error handling by catching additional failures when snap configuration cannot be retrieved, improving stability during config operations.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3971 snap config: do not crash when config cannot be retrieved snapcraft merged Merged. Fixed a crash in get_snap_config() when snapd is unavailable by catching and logging errors. Approved by reviewer and passed CI checks.
82%
#497 fix(config): warn on snapctl errors craft-application merged Merged a configuration fix that warns on snapctl errors. Approved by two reviewers, the change adds 32 lines across two files and addresses pending review feedback.
76%
#1325 cli: proper error for failed snap command snapcraft merged Merged: returns a proper error code when a snap command fails. Approved by one reviewer with no unresolved comments. Changes span two files (+15/-2).
75%
#1815 repo: handle invalid snaps snapcraft merged Merged changes handling invalid snaps in build-snaps with a clear error message. Adds retries to information fetching for improved network failure debugging. Approved after resolving a minor CI typo.
73%
#499 fix(config): wrap snap config handler in snap check craft-application merged Merged a fix wrapping the snap config handler in a snap environment check to prevent execution errors outside snaps. Approved by two reviewers, passed CI, and introduced 12 lines across two files.
73%
#1499 repo: make errors based on SnapcraftError snapcraft merged Merged a fix preventing repo-based errors from triggering tracebacks outside debug mode by inheriting from SnapcraftError. Approved by two reviewers, passed CI, and resolves an oversight from PR #1436.
71%
#171 fix(snap): update config dir in post-refresh hook fetch-service merged Merged a fix updating the ACL configuration file path in the snap post-refresh hook. Approved by three reviewers and passed CI checks.
70%