← Back to issue list

Support cleaning pull step.

View original Github issue

Metadata

Project
snapcraft
Number
#400
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #400 in commit 173d0955a, adding plugin clean_pull() support and targeted pull cleanup for Go, Node.js, and Catkin plugins.

Resolution: closed resolved

Reason: PR #400 was merged as commit 173d0955a. It added clean_pull() to the plugin API and reimplemented pull-step cleanup for the Go, Node.js, and Catkin plugins.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR finishes up LP: [#1537786](https://bugs.launchpad.net/snapcraft/+bug/1537786) by adding the ability to clean only a part's pulled files. This involves adding a new `clean_pull()` method to the plugin API as there are a few plugins that have more involved pull steps than the base implementation's. This commit also reimplements clean_pull() for the Go, NodeJS, and Catkin plugins. Depends upon #398.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #400 in commit 173d0955a, adding plugin clean_pull() support and targeted pull cleanup for Go, Node.js, and Catkin plugins.
stealth/space-bunny-alpha — closed resolved Merged PR #400 added clean_pull() to the plugin API and reimplemented it for Go, NodeJS, and Catkin, completing per-step cleanup after #398. Commit 173d0955a.
qwen/qwen3.6-35b-a3b — — Merged. Introduced a clean_pull() method to the plugin API to selectively clean pulled files for individual parts, with reimplementations for Go, NodeJS, and Catkin plugins. Approved and merged following positive reviews.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Introduces a clean_pull method to the plugin API for selectively cleaning pulled files per part. Reimplemented for Go, NodeJS, and Catkin plugins. Approved and merged following successful coverage checks and maintainer reviews.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#398 (confidence 100%)

    The PR explicitly depended on #398, which added build-step cleanup support.

Related issues

Issue Project State Summary Similarity
#398 Support cleaning build step. snapcraft merged Merged via snapcraft#401 as commit 5904250f8, adding clean_build() to the plugin API and Go plugin so only a part's built files are cleaned.
73%