← Back to issue list

providers: push .bashrc to Multipass instances

View original Github issue

Metadata

Project
snapcraft
Number
#4010
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #4010 merged as commit 3b6220cb: re-enabled pushing .bashrc into Multipass instances via craft-providers push_file_io, dropping the host temp-file workaround added in #3967 (CRAFT-1545).

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit 3b6220cb, restoring .bashrc transfer to Multipass instances now that craft-providers#193 supports it and using push_file_io instead of a host temporary file. Follow-up #4016 fixed the lint failure that briefly blocked CI.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- 1. Allow `.bashrc` to be pushed into Multipass instances. This is now possible due to [this `craft-providers` PR](https://github.com/canonical/craft-providers/pull/193) being merged. 2. Stop writing `.bashrc` to a temporary file on the host. Instead, use `craft-providers` method `push_file_io`. (CRAFT-1545)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #4010 merged as commit 3b6220cb: re-enabled pushing .bashrc into Multipass instances via craft-providers push_file_io, dropping the host temp-file workaround added in #3967 (CRAFT-1545).
stealth/space-bunny-alpha — closed resolved Merged PR #4010 as commit 3b6220cb, adding Multipass .bashrc transfer via craft-providers.push_file_io and removing the temporary host file.
qwen/qwen3.6-35b-a3b — — Merged. Replaces temporary host file creation with craft-providers.push_file_io to push .bashrc directly into Multipass instances. Approved by two reviewers, passed CI, and merged into main.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Replaces temporary host file creation with craft-providers.push_file_io to directly push .bashrc to Multipass instances. Code coverage increased by 0.07%, with linting fixes applied in a follow-up PR.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcore/snapcraft#3967 (confidence 90%)

    Earlier merged PR (commit 2a8d07b) that temporarily stopped pushing .bashrc to Multipass; #4010 reverses that workaround.

  • Related To: snapcore/snapcraft#4016 (confidence 70%)

    Follow-up PR (commit 5b8ad3d) freezing Ruff to fix the ruff/tox lint failure that blocked this PR's CI.

Related issues

Issue Project State Summary Similarity
#3967 providers: do not push .bashrc to Multipass instances snapcraft merged Merged as 2a8d07b24 to skip pushing .bashrc to Multipass; later superseded by #4010 (3b6220cb), which restored it.
84%
#193 MultipassInstance: `push_file_io()` method works regardless of working dir craft-providers merged Merged PR #193 in commit a41d0b4, fixing MultipassInstance.push_file_io() to work regardless of host working-directory permissions; released in craft-providers 1.7.0.
73%