← Back to issue list

extension: use minimum necessary build packages for ros foxy extension (core20)

View original Github issue

Metadata

Project
snapcraft
Number
#4019
Type
pull request
State
merged
Author
artivis
Labels
Created
Updated
Closed

Current evaluation

Merged optimization for ROS 2 Foxy extension build packages on core20. The update also fixed a bug where ROS underlay environments were not properly sourced, applying the fix to core20 and core22.

Suggested action:

No scores available.

Issue body

Install the minimum necessary build packages for the ROS 2 Foxy extension (core20). This change unearthed a related underlying bug, not all ROS underlay were properly sourced. This PR fixes that issue as well for both core20 & core22. Signed-off-by: artivis <jeremie.deray@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged optimization for ROS 2 Foxy extension build packages on core20. The update also fixed a bug where ROS underlay environments were not properly sourced, applying the fix to core20 and core22.
qwen3.6-35b-a3b-mtp-q6 Merged to minimize build packages for the ROS 2 Foxy extension on core20. The update also resolved a bug where ROS underlay environments were not properly sourced, applying the fix to core20 and core22. Approved and merged into main.
qwen3.6-35b-a3b-mtp-q6 Merged optimization to use minimal build packages for the ROS 2 Foxy extension on core20. The change also fixed a bug where ROS underlay environments were not properly sourced, applying the fix to both core20 and core22. Approved and merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6315 fix(extensions/ros): fix ros 2 extension core26 snapcraft merged Merged fix for the ROS 2 extension on Core 26. Added a no-op all target to the launch Makefile to prevent empty DESTDIR install failures. Reordered command-chain exports to ensure python3 is on PATH before sourcing workspaces, resolving runtime errors.
72%
#3203 experimental ros2 extension & colcon v2 plugin snapcraft merged Merged experimental ROS2 extension and colcon v2 plugin. Rebased and approved to enable Foxy support. Integrated into master with 790 lines added across 16 files.
72%