← Back to issue list

extension: use minimum necessary build packages for ros foxy extension (core20)

View original Github issue

Metadata

Project
snapcraft
Number
#4019
Type
pull request
State
merged
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4019 (63c19ed37), minimizing ROS 2 Foxy core20 build packages and fixing ROS underlay sourcing for core20 and core22.

Resolution: closed resolved

Reason: PR #4019 was approved and merged as commit 63c19ed37, reducing the required build packages and correcting underlay sourcing on core20 and core22.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Install the minimum necessary build packages for the ROS 2 Foxy extension (core20). This change unearthed a related underlying bug, not all ROS underlay were properly sourced. This PR fixes that issue as well for both core20 & core22. Signed-off-by: artivis <jeremie.deray@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4019 (63c19ed37), minimizing ROS 2 Foxy core20 build packages and fixing ROS underlay sourcing for core20 and core22.
stealth/space-bunny-alpha — closed resolved Merged #4019, minimizing ROS 2 Foxy core20 build dependencies and fixing ROS underlay sourcing for core20 and core22.
stealth/space-bunny-alpha — closed resolved Merged PR #4019 (69fd88f), reducing ROS 2 Foxy build packages on core20 and fixing ROS underlay sourcing for core20 and core22.
qwen/qwen3.6-35b-a3b — — Merged optimization for ROS 2 Foxy extension build packages on core20. The update also fixed a bug where ROS underlay environments were not properly sourced, applying the fix to core20 and core22.
qwen3.6-35b-a3b-mtp-q6 — — Merged to minimize build packages for the ROS 2 Foxy extension on core20. The update also resolved a bug where ROS underlay environments were not properly sourced, applying the fix to core20 and core22. Approved and merged into main.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6315 fix(extensions/ros): fix ros 2 extension core26 snapcraft merged Merged as 429f62894, fixing ROS 2 core26 builds by making bare make a no-op, ordering underlay PATH setup before workspace sourcing, and updating spread tests.
73%