← Back to issue list

requirements: pin setuptools<66

View original Github issue

Metadata

Project
snapcraft
Number
#4031
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged pinning setuptools below 66. Version 66 enforces PEP 440, breaking unit tests. The fix adds a TODO for future resolution, passed CI, and received four approvals.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- [`setuptools>=66`](https://setuptools.pypa.io/en/stable/history.html#v66-0-0) enforces versioning requirements from [PEP 440](https://peps.python.org/pep-0440/), which causes some of the unit tests to fail. Added comments and a TODO so it can be resolved in the future.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged pinning setuptools below 66. Version 66 enforces PEP 440, breaking unit tests. The fix adds a TODO for future resolution, passed CI, and received four approvals.
qwen3.6-35b-a3b-mtp-q6 Merged to main. Pins setuptools below version 66 to prevent PEP 440 enforcement from breaking unit tests. Includes a TODO for future resolution. Code coverage unchanged.
qwen3.6-35b-a3b-mtp-q6 Merged a requirements update pinning setuptools below version 66 to prevent PEP 440 enforcement from breaking unit tests. Includes a future TODO and was merged into main without impacting coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3261 requirements: pin setuptools devel requirement snapcraft merged Merged changes pinning the setuptools development requirement. Approved by one reviewer, passed CI checks, and modified one file with a single line addition.
78%
#628 build(deps): pin overrides!=7.6.0 craft-parts merged Merged a dependency pin to exclude overrides version 7.6.0, which introduced a bug breaking Python plugin tests using the override decorator. The change was approved, passed CI, and was temporarily closed and reopened to resolve a readthedocs failure.
70%