← Back to issue list

requirements: pin setuptools<66

View original Github issue

Metadata

Project
snapcraft
Number
#4031
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #4031 merged as commit 709e16c78 ("requirements: pin setuptools<66"), adding a setuptools<66 pin plus comments/TODO so unit tests stopped failing under setuptools>=66's stricter PEP 440 version enforcement.

Resolution: closed resolved

Reason: The pull request itself was merged into main as commit 709e16c78 with +4 lines across 2 files, pinning setuptools<66 in the requirements to work around the PEP 440 version-spec enforcement introduced in setuptools 66 that broke unit tests. The pin was later superseded by Dependabot bumps (a1c10a749 to v69, afde69391 to v84) after the underlying test versions were fixed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- [`setuptools>=66`](https://setuptools.pypa.io/en/stable/history.html#v66-0-0) enforces versioning requirements from [PEP 440](https://peps.python.org/pep-0440/), which causes some of the unit tests to fail. Added comments and a TODO so it can be resolved in the future.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #4031 merged as commit 709e16c78 ("requirements: pin setuptools<66"), adding a setuptools<66 pin plus comments/TODO so unit tests stopped failing under setuptools>=66's stricter PEP 440 version enforcement.
stealth/space-bunny-alpha — closed resolved Merged PR #4031, pinning setuptools<66 to avoid PEP 440 enforcement breaking unit tests; added a TODO for a future fix in commit 709e16c7.
qwen/qwen3.6-35b-a3b — — Merged pinning setuptools below 66. Version 66 enforces PEP 440, breaking unit tests. The fix adds a TODO for future resolution, passed CI, and received four approvals.
qwen3.6-35b-a3b-mtp-q6 — — Merged to main. Pins setuptools below version 66 to prevent PEP 440 enforcement from breaking unit tests. Includes a TODO for future resolution. Code coverage unchanged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3261 requirements: pin setuptools devel requirement snapcraft merged Merged PR #3261 via commit c23eda2b8, pinning the setuptools development requirement in requirements-devel.txt.
78%
#188 chore(deps): update dependency setuptools to v69.1.0 - autoclosed starbase closed Autoclosed unmerged setuptools 69.1.0 pin bump; PR #190 (commit 9d271a7) instead loosened the build requirement, superseding the exact-pin update.
71%
#28 chore(deps): update dependency setuptools to v67.4.0 craft-archives merged Renovate dependency bump of pinned setuptools 67.3.2 -> 67.4.0 approved and merged; landed as commit 1c93776 (only tox.ini pin changed).
71%