Clean: Leave local plugins alone.
Metadata
Current evaluation
Merged PR #404 via b399a5ebd (fix commit 5094d08b2), preserving local plugins during clean and adding regression tests for LP #1561546; released in Snapcraft 2.6.1.
Resolution: closed resolved
Reason: PR #404 was merged with implementation commit 5094d08b2. It checks for local plugins before removing parts/ and adds regression tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Currently Snapcraft will remove the parts directory if no parts are using it, but it doesn't take into account the fact that local plugins are kept in there, and will remove them. This PR fixes LP: [#1561546](https://bugs.launchpad.net/snapcraft/+bug/1561546) by checking for local plugins before removing the parts directory. It also adds tests so that this regression can't happen again.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #404 via b399a5ebd (fix commit 5094d08b2), preserving local plugins during clean and adding regression tests for LP #1561546; released in Snapcraft 2.6.1. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #404 fixed cleanup deleting local plugins by preserving parts/ when plugins exist; fix commit 5094d08b2 was merged via b399a5ebd. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#404 (commit 5094d08b2), preserving local plugins in parts/ during clean and adding regression tests for LP #1561546. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix preventing Snapcraft from deleting the parts directory when local plugins are present. Added a pre-removal check and regression tests to resolve Launchpad bug #1561546. Integrated into master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix preventing Snapcraft from deleting local plugins stored in the parts directory during cleanup. Adds a preservation check and regression tests, resolving LP #1561546. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#405
(confidence 95%)
Merged release PR for Snapcraft 2.6.1, which included the fix.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1561546 Snapcraft clean removes local plugins | snapcraft (launchpad) | closed | Clean removing local plugins was fixed by merged PR #404 (fix commit 5094d08b2), released in Snapcraft 2.6.1; the issue was closed by maintainer kyrofa with that link. | |
| #88 Clean for parts and removal of duped code for lifecycle and the BasePlugin | snapcraft | merged | Merged in snapcraft#88 (272c2d6e8), adding per-part cleanup and consolidating lifecycle/BasePlugin directory ownership to remove duplicated code. |