← Back to issue list

utils: log envvar SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT when invalid

View original Github issue

Metadata

Project
snapcraft
Number
#4041
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main. Adds logging for the SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variable when invalid. Approved by reviewer, passed CI, and contains no functional changes.

Suggested action: —

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- No functional changes. Minor logging improvement to log the environment variable `SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT` when it is invalid.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into main. Adds logging for the SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variable when invalid. Approved by reviewer, passed CI, and contains no functional changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Adds logging for invalid SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variable without functional changes. Approved by maintainer mr-cal with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Adds logging for invalid SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variables. No functional changes. Achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3997 providers: pass SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT to instance snapcraft merged Merged into main. Resolves a bug where the SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variable was not passed to the build instance, ensuring correct parallel build limits during snap creation.
80%
#1154 Expose parallel_build_count to scriptlets (LP: #1666271). snapcraft merged Merged after exposing parallel_build_count to scriptlets. A reviewer requested renaming the variable to SNAPCRAFT_PARALLEL_BUILD_COUNT, which the author agreed to. Approved and merged with 29 additions and 1 deletion across 4 files.
72%
#2179 cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated snapcraft merged Merged into master after approval and CI. Fixed a misleading deprecation warning that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT instead of SNAPCRAFT_CONTAINER_BUILDS. Updated two lines to correct the error message.
72%
#2122 many: introduce variables for part src and build snapcraft merged Merged following approval. Introduces new environment variables and replacements for part src and build directories, resolving LP #1763028. Consolidates SNAPCRAFT_* environment handling into a single location. Approved by one reviewer with passing CI checks.
72%
#212 Incorrectly handling SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT craft-providers open Issue with SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT handling and incorrect CPU counts in Multipass. Maintainer is addressing via craft-application integration.
72%
#1996 tests: add SNAPCRAFT_KEEP_DATA to debug snapcraft merged Merged test updates adding the SNAPCRAFT_KEEP_DATA environment variable for debugging. Approved by two reviewers, the change modifies two files with a net addition of 14 lines. Submitted as a farewell gift to @sergiusens.
71%
#2696 shell_utils: Add SNAPCRAFT_DEBUG_SCRIPTS env variable snapcraft closed Superseded by another PR that implemented the SNAPCRAFT_DEBUG_SCRIPTS feature. Maintainers noted the merged code requires adjustments based on discussions in this closed request, which remains abandoned with unresolved review comments.
71%
#2130 tests: remove obsolete env var snapcraft merged Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following underlying logic deletion. Approved by one reviewer with passing CI checks, the update deletes four lines across one file.
71%
#2534 Add SNAPCRAFT_PROJECT_DIR environment variable. snapcraft merged Merged after approval and CI checks. Adds SNAPCRAFT_PROJECT_DIR environment variable pointing to the project directory. Resolves Launchpad bug 1824417. Reviewer noted minor coverage decrease and suggested follow-up integration tests.
70%