cli: better checking for experimental plugins
Metadata
Current evaluation
Merged as 66421cd6c: Snapcraft now checks command-specific parsed arguments when determining whether experimental plugins are enabled.
Resolution: closed resolved
Reason: PR snapcore/snapcraft#4092 was approved and merged as commit 66421cd6c. It reads enable_experimental_plugins from command-specific arguments, avoiding incorrect detection caused by craft-cli not forwarding global arguments.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Global arguments in craft-cli are not passed to command handlers, so verify if experimental plugins are enabled using command-specific arguments.
Future improvements may include global argument refactoring in craft-cli and experimental plugin support in craft-parts.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 66421cd6c: Snapcraft now checks command-specific parsed arguments when determining whether experimental plugins are enabled. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 66421cd6c: experimental-plugin checks now use command-specific arguments because craft-cli does not forward global arguments. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#4092, improving experimental-plugin checks by using command-specific arguments because craft-cli does not pass global arguments to handlers. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#4092 as commit 66421cd6c, improving experimental plugin detection by using command-specific arguments because craft-cli does not pass global arguments. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to improve CLI experimental plugin detection by using command-specific arguments instead of global arguments, addressing a craft-cli limitation. Approved by one reviewer, passed CI checks, and modified 7 files (+93/-23 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates craft-cli to verify experimental plugins using command-specific arguments instead of global ones, fixing a handler argument passing issue. Codecov coverage warnings were noted but did not block the merge. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcore/snapcraft#4085
(confidence 96%)
#4085 introduced the experimental-plugin opt-in; #4092 corrected how its command argument is detected.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4093 cli: add option to enable experimental plugins for snapcraft_legacy | snapcraft | merged | Merged in snapcore/snapcraft#4093 (937e52959), adding core18/core20 support for experimental extensions via the CLI option or environment variable in snapcraft_legacy. | |
| #4085 cli: add option to enable experimental plugins | snapcraft | merged | PR #4085 by cmatsuoka merged as commit 0133b4b3e, adding a global --enable-experimental-plugins CLI flag (plus SNAPCRAFT_ENABLE_EXPERIMENTAL_PLUGINS) so the kernel plugin and other unstable plugins can be used; still present at HEAD. | |
| #3197 experimental extension support | snapcraft | merged | Merged PR #3197 (commit be00472e5) added experimental extension support to snapcraft, landed after its prerequisite PR #3196 (c1a41fd84) which unset false boolean CLI flags. |