← Back to issue list

cli: better checking for experimental plugins

View original Github issue

Metadata

Project
snapcraft
Number
#4092
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged changes to improve CLI experimental plugin detection by using command-specific arguments instead of global arguments, addressing a craft-cli limitation. Approved by one reviewer, passed CI checks, and modified 7 files (+93/-23 lines).

Suggested action:

No scores available.

Issue body

Global arguments in craft-cli are not passed to command handlers, so verify if experimental plugins are enabled using command-specific arguments. Future improvements may include global argument refactoring in craft-cli and experimental plugin support in craft-parts. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes to improve CLI experimental plugin detection by using command-specific arguments instead of global arguments, addressing a craft-cli limitation. Approved by one reviewer, passed CI checks, and modified 7 files (+93/-23 lines).
qwen3.6-35b-a3b-mtp-q6 Merged. Updates craft-cli to verify experimental plugins using command-specific arguments instead of global ones, fixing a handler argument passing issue. Codecov coverage warnings were noted but did not block the merge.
qwen3.6-35b-a3b-mtp-q6 Merged. Switched experimental plugin verification to command-specific arguments to bypass craft-cli global argument handling. The fix passed checks and was integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4085 cli: add option to enable experimental plugins snapcraft merged Merged. Adds CLI flag --enable-experimental-plugins and env var SNAPCRAFT_ENABLE_EXPERIMENTAL_PLUGINS to enable experimental plugins. Approved by reviewer, passed CI, and merged with 34 additions and 8 deletions across 3 files.
80%
#3266 cli: add --enable-experimental-extensions option for expand-extensions snapcraft merged Merged. Added --enable-experimental-extensions CLI flag to expand-extensions. Approved by one reviewer, passed CI checks, and committed with 13 additions and 3 deletions across one file.
74%
#26 cli: parse command line using craft-cli rockcraft merged Merged after approval and passing CI. Replaced the temporary CLI parser with craft-cli's subsystem and defined the pack command. Modified 12 files, adding 144 lines and removing 197.
72%