← Back to issue list

meta: disallow Snap channel in default_provider

View original Github issue

Metadata

Project
snapcraft
Number
#4096
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main after two approvals. Added validation to disallow Snap channels in default_provider, including a legacy check and unit tests. Passed CI with 100% diff coverage.

Suggested action: —

No scores available.

Issue body

Add extra validations for default_provider. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into main after two approvals. Added validation to disallow Snap channels in default_provider, including a legacy check and unit tests. Passed CI with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Implements validation to disallow Snap channels in default_provider and legacy providers. Reviewers approved the logic and requested additional tests, which were added before final merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main after adding validation to disallow Snap channels in default_provider and legacy providers. Reviewer approved the legacy check and requested a corresponding test, which was incorporated before final merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2507 build providers: improve handling in snap logic snapcraft merged Merged. Improved snap provider logic by cleaning up channel warnings, removing unnecessary sudo calls, and silencing noisy refresh hold commands. Approved, passed CI, and modified 5 files (+131/-73 lines).
76%
#3146 build providers: snap sw to channels if injecting snapcraft merged Merged fix that prevents automatic channel switching to latest/stable when injecting snaps with revision assertions during build provider setup. Approved by reviewer, passed CI, and integrated.
76%