meta: disallow Snap channel in default_provider
Metadata
Current evaluation
Merged PR #4096 (commit 603e1499b), rejecting channel-qualified Snap providers in default_provider, including legacy validation and unit tests.
Resolution: closed resolved
Reason: PR #4096 was merged into main as commit 603e1499b. It added validation preventing Snap channels in default_provider for both current and legacy paths, with unit coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Add extra validations for default_provider.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4096 (commit 603e1499b), rejecting channel-qualified Snap providers in default_provider, including legacy validation and unit tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #4096 (commit 603e1499b), adding validation that rejects Snap channels in default_provider, including a legacy-provider check and unit tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4096 (commit 603e1499b) after two approvals, adding validation to reject Snap channels in default_provider, including a legacy check and unit tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #4096 (commit 603e1499b): added validation rejecting Snap channels in default_provider, including legacy metadata validation and unit tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after two approvals. Added validation to disallow Snap channels in default_provider, including a legacy check and unit tests. Passed CI with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Implements validation to disallow Snap channels in default_provider and legacy providers. Reviewers approved the logic and requested additional tests, which were added before final merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2012057 `base: core22` `default-provider:` allows channels, but SnapD doesn't | snapcraft (launchpad) | closed | Snapcraft now rejects channels in default-provider values, aligning it with snapd; fixed by canonical/snapcraft#4096 in commit 603e1499b. | |
| #3146 build providers: snap sw to channels if injecting | snapcraft | merged | Merged PR #3146 as commit c15f0623d, preventing revision-asserted injected snaps from being switched to latest/stable and preserving their intended tracking channels. |