← Back to issue list

projects: warn on "global" assign of plugs and slots

View original Github issue

Metadata

Project
snapcraft
Number
#4097
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged into main. Adds a warning for top-level plug and slot assignments in snapcraft.yaml, replacing deprecated global configuration. Approved by reviewer, passed CI, and incorporated a minor wording adjustment prior to merge.

Suggested action:

No scores available.

Issue body

This commit adds a warning (via emit.message()) when a snapcraft.yaml project has top-level plugs and/or slots that are used for assignment and not per-plug/slot configuration. Thanks to lucyllewy for suggested wording of the warning. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main. Adds a warning for top-level plug and slot assignments in snapcraft.yaml, replacing deprecated global configuration. Approved by reviewer, passed CI, and incorporated a minor wording adjustment prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Adds a warning for top-level plug and slot assignments in snapcraft.yaml. Warning wording was refined for clarity. Accepted with 100% diff coverage despite a 0.01% overall decrease.
qwen3.6-35b-a3b-mtp-q6 Merged into main, adding a warning for top-level plug and slot assignments in snapcraft.yaml. The warning text was refined based on feedback. The change achieved 100% diff coverage before merging.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4765 chore: update link for top level plug and slots warning snapcraft merged Merged after approval and CI. Updated documentation link for the top-level plug and slot warning per reviewer feedback. Aligns with snapd's long-term plan to stop applying globally-defined plugs and slots to individual apps.
75%
#2884 plugs/slots: match output format read in snapcraft.yaml snapcraft merged Merged to align snap.yaml output with snapcraft.yaml input by restoring 3.8 plugs/slots formatting. This change works around a review-tools bug and ensures syntax consistency. Approved by one reviewer, passed CI, and modified six files.
71%