← Back to issue list

projects: warn on "global" assign of plugs and slots

View original Github issue

Metadata

Project
snapcraft
Number
#4097
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4097 (commit 1c9214f), adding warnings when snapcraft.yaml globally assigns plugs or slots instead of assigning them per app.

Resolution: closed resolved

Reason: PR #4097 was merged into main as commit 1c9214f. It added emit.message warnings for implicit top-level plug or slot assignment, with unit and spread-test coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit adds a warning (via emit.message()) when a snapcraft.yaml project has top-level plugs and/or slots that are used for assignment and not per-plug/slot configuration. Thanks to lucyllewy for suggested wording of the warning. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4097 (commit 1c9214f), adding warnings when snapcraft.yaml globally assigns plugs or slots instead of assigning them per app.
stealth/space-bunny-alpha — closed resolved Merged into main as commit 61d519eec (#4097), adding warnings for top-level plug and slot assignments in snapcraft.yaml and revising warning wording before merge.
qwen/qwen3.6-35b-a3b — — Merged into main. Adds a warning for top-level plug and slot assignments in snapcraft.yaml, replacing deprecated global configuration. Approved by reviewer, passed CI, and incorporated a minor wording adjustment prior to merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Adds a warning for top-level plug and slot assignments in snapcraft.yaml. Warning wording was refined for clarity. Accepted with 100% diff coverage despite a 0.01% overall decrease.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.