← Back to issue list

spread: improve resilience of lxd-type-base test

View original Github issue

Metadata

Project
snapcraft
Number
#4239
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged via squash to improve resilience of the lxd-type-base test, fixing frequent lxc stop timeouts on Google runners. Approved by reviewers with passing CI checks.

Suggested action: —

No scores available.

Issue body

This test often times out on `lxc stop` on Google runners. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- #4236

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged via squash to improve resilience of the lxd-type-base test, fixing frequent lxc stop timeouts on Google runners. Approved by reviewers with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Squash merged into main. The change improves resilience of the lxd-type-base test, preventing frequent timeouts on Google runners.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main after squashing. The change improves resilience of the lxd-type-base test to prevent timeouts on Google runners. Review confirmed no coverage impact, and the commit was integrated without merge commits.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4236 lxd-type-base spread test is flaky due to lxd timeouts snapcraft closed Resolved flaky spread test failures caused by LXD container stop timeouts. Closed via pull request #4239.
75%
#2983 tests: add LXD spread test snapcraft merged Merged after reviewer approval and passing CI checks. Added LXD spread test to verify LXD builds and installs. Modified two files with 29 added lines.
73%
#3112 spread: remove dead code for lxd setup and add debug prints snapcraft merged Merged removal of redundant elif dead code in LXD setup logic and addition of debug prints for LXD snap install failures. Approved by one reviewer, passed CI checks, and integrated.
71%
#1771 lxd: suppress traceback when lxc launch / init fails snapcraft merged Merged to suppress tracebacks when lxc launch or init fails, relying on lxc's native error output. Approved by one reviewer, modifying three files (+35/-15).
71%
#2631 spread tests: enable LXD build provider tests snapcraft merged Merged into master. Enabled LXD build provider tests by relocating setup to the early prepare phase to reduce overhead and consolidating declarations from task.yaml to spread.yaml. Approved, passed CI, and increased coverage by 0.01%.
71%
#1803 fix(tests): speed up lxd smoke test charmcraft merged Merged to resolve lxd smoke test timeouts by reducing execution time through a broken charm build. Approved by two reviewers with a six-line code change.
71%
#3120 spread: only run in LXD with the google/multipass provider for repo snapcraft merged Merged changes restricting spread tests to LXD with the google/multipass provider for the repo. Switched autopkgtest to destructive mode to bypass dirmngr failures until the environment is verified. Approved and passed CI.
71%
#1758 tests: move the ppa test trigger to lxd snapcraft merged Merged changes moving the PPA test trigger from Docker to LXD to streamline future debugging. The original failure was valid, but the environment shift improves test maintainability. Approved by reviewers and passed all CI checks.
70%
#5856 fix(spread): pack with lxd for core20 base tests snapcraft merged Merged after two approvals. Updates spread tests to pack with LXD for core20 base tests. CI passed with one non-blocking schema diff failure. Related core20 and snapd test failures were resolved in separate PRs.
70%
#3180 build providers: nice message on bad base snapcraft merged Merged implementation adding a new exception to handle invalid bases in LXD build providers, providing clearer error messages. Resolves SNAPCRAFT-1H2. Approved by one reviewer, passed CI, and modified 4 files (+77/-14).
70%