← Back to issue list

spread: disable godeps tests

View original Github issue

Metadata

Project
snapcraft
Number
#4249
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4249 (aa3d5d67f), disabling spread godeps tests after golang/go#57051 broke builds while retaining the feature for a future fix.

Resolution: closed resolved

Reason: PR #4249 was merged as commit aa3d5d67f. It disables the spread godeps tests because golang/go#57051 prevents godeps from building, while preserving the feature pending an upstream fix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

godeps can not longer build due to https://github.com/golang/go/issues/57051 Instead of removing the godeps feature, disable the tests in case the upstream fixes the problem. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4249 (aa3d5d67f), disabling spread godeps tests after golang/go#57051 broke builds while retaining the feature for a future fix.
stealth/space-bunny-alpha — closed resolved Merged PR #4249 (commit aa3d5d67f) disabled spread’s godeps tests because Go #57051 broke builds, retaining godeps support for a future upstream fix.
qwen/qwen3.6-35b-a3b — — Merged changes disabling godeps tests due to an upstream Go build failure. Tests are skipped to preserve the feature for future fixes rather than removing it. Approved and merged into hotfix/7.5.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.5. Disabled godeps tests following upstream Go build failure. The feature remains intact to accommodate potential upstream fixes, with zero coverage impact.

Update history

No update history recorded yet.

Related work

  • Blocked By: go#57051 (confidence 100%)

    The upstream Go issue broke godeps builds and prompted the tests to be disabled.

Related issues

Issue Project State Summary Similarity
#3431 godeps spread test: use latest/stable go snap snapcraft merged Merged PR #3431 as commit f21a0132a, updating godeps spread tests to use the latest/stable Go snap instead of Xenial's Go 1.6.
77%
#1783833 Move Godeps plugin tests to spread snapcraft (launchpad) closed Godeps integration tests were migrated from Python to Spread by merged snapcraft PR #2200, resolving LP #1783833 in commit 84932cc48.
73%
#1197 ci: temporarily disable externally broken spread tests charmcraft merged Merged PR #1197 as commit 4b34df89, temporarily disabling spread tests broken by third-party dependency issues; re-enablement is tracked in #1193.
72%
#2200 tests: add spread suite for godeps plugin snapcraft merged Merged #2200 in commit 84932cc48, moving Godeps plugin integration tests to a Spread suite and resolving LP #1783833.
72%