← Back to issue list

plugins: add riscv into kernel plugin for build dtbs

View original Github issue

Metadata

Project
snapcraft
Number
#4252
Type
pull request
State
merged
Author
AristoChen
Labels
Created
Updated
Closed

Current evaluation

Merged into main. The kernel plugin now builds dtbs for RISC-V by adding riscv to the architecture check, fixing the missing dtbs generation. Approved and passed CI.

Suggested action:

No scores available.

Issue body

Hi, I was using kernel plugin to build a RISC-V kernel, but it won't build `dtbs`, and I found it will append `dtbs` only if `ARCH` matches `arm`, `arm64` or `riscv64`, however, the `ARCH` in my case is `riscv`. The following are some logs Before the code change: ``` 2023-07-01 23:03:45.814 :: Building kernel... 2023-07-01 23:03:45.814 :: ++ nproc 2023-07-01 23:03:45.816 :: + make -j8 -C /home/vagrant/aristo/UbuntuCoreOS/cache/starfive_visionfive2_backup/kernel_snap/parts/kernel/src O=/home/vagrant/aristo/UbuntuCoreOS/cache/starfive_visionfive2_backup/kernel_snap/parts/kernel/build ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- Image modules ``` After the code change: ``` 2023-07-01 23:27:34.931 :: Building kernel... 2023-07-01 23:27:34.931 :: ++ nproc 2023-07-01 23:27:34.932 :: + make -j8 -C /home/vagrant/aristo/UbuntuCoreOS/cache/starfive_visionfive2_backup/kernel_snap/parts/kernel/src O=/home/vagrant/aristo/UbuntuCoreOS/cache/starfive_visionfive2_backup/kernel_snap/parts/kernel/build ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- Image modules dtbs ``` - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main. The kernel plugin now builds dtbs for RISC-V by adding riscv to the architecture check, fixing the missing dtbs generation. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds riscv architecture to the kernel plugin dtbs build condition, resolving device tree blob generation failures for RISC-V. Integrated into main.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Updates the kernel plugin to include riscv in the architecture check, enabling dtbs builds for ARCH=riscv. Resolves the missing dtbs compilation issue for 32-bit RISC-V targets.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1148 kernel plugin: if dtb target == NULL and arch == (arm||arm64), build and install all dtbs snapcraft merged Merged. Modifies the kernel plugin to automatically build and install all device tree blobs for ARM and ARM64 architectures when the dtb target is unspecified. Approved by reviewer and integrated into the main branch.
73%