← Back to issue list

package-repositories: update craft-archives to support multi-keys.

View original Github issue

Metadata

Project
snapcraft
Number
#4253
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. Updates craft-archives to support multi-keys for package-repositories. Codecov reported no coverage change, while an unrelated spread error was tracked in PR #4256.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI. Updates craft-archives to support multi-keys for package-repositories. Codecov reported no coverage change, while an unrelated spread error was tracked in PR #4256.
qwen3.6-35b-a3b-mtp-q6 Merged into hotfix/7.5, updating craft-archives to support multi-keys for package repositories. Codecov reports no coverage impact. Follow-up issue #4256 tracks a related spread error.
qwen3.6-35b-a3b-mtp-q6 Merged into hotfix/7.5, updating craft-archives to support multi-keys in package repositories. Codecov reports no coverage change. A related spread error was tracked separately in PR #4256.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4079 update craft-archives and support apt pinning snapcraft merged Merged into main after approval and passing CI. Updates craft-archives to v0.0.3, restructures key handling, and adds apt repository pinning support. Resolves CRAFT-1646 with 100% diff coverage.
77%
#217 repo: add support for package repositories rockcraft merged Added support for package repositories. Merged after approval by two reviewers and passing CI checks. Modified 16 files (+346/-31), resolving CRAFT-1553 and enabling downstream testing.
74%
#4174 requirements: update craft-archives snapcraft merged Merged update to the craft-archives dependency in project requirements. Approved by one reviewer with no unresolved comments. Code coverage remained unchanged upon integration into the main branch.
73%
#4037 repo: Migrate to craft-archives snapcraft merged Merged craft-archives migration, replacing 4547 lines with 28 across 34 files. Approved by two reviewers, passed CI, and merged to main. Codecov noted a minor coverage drop with 100% diff coverage. Unrelated spread timeouts did not block the merge.
73%
#32 keys: per-repository keyrings craft-archives merged Merged per-repository keyrings implementation (CRAFT-1627). Approved by two reviewers, passed CI, and changed nine files with a 2.14% coverage increase. Lint and test refinements were deferred to follow-up PRs.
72%
#23 Use the package-repositories stanza in imagecraft.yaml imagecraft merged Merged implementation of the package-repositories stanza in imagecraft.yaml via craft-archives. Includes Project model enhancements, code refactoring, and expanded test coverage at 97.66%. Resolves FR-5873.
72%
#5412 test: update multi-key test for package repositories snapcraft merged Merged test updates adding a new valid GPG key to replace an expired apt.puppet.com key, resolving failing multi-key repository tests. The change passed review and CI. Reviewers recommended migrating to a team-controlled PPA to prevent future expiration issues.
71%
#4279 repos: revert package-repositories changes for core18 and core20 snapcraft merged Merged a revert of package-repositories changes for core18 and core20 to restore original pre-craft-archives support. Approved, passed CI, and merged into hotfix/7.5, modifying 13 files with 2019 additions and 16 deletions.
71%
#4235 requirements: bump craft-archives to fix regression snapcraft closed Merged into hotfix/7.4 to bump craft-archives, resolving regression #4224. The update restores support for asset files containing multiple keys, aligning with the previous apt-key behavior.
71%
#276 requirements: update craft-archives rockcraft merged Merged after updating the craft-archives dependency. Approved by two reviewers and passed CI. Comments noted unrelated flaky spread tests linked to an upstream LXD bug, which did not block the merge.
71%