← Back to issue list

commands: fix missing built_at store upload option

View original Github issue

Metadata

Project
snapcraft
Number
#4261
Type
pull request
State
merged
Author
suligap
Labels
Created
Updated
Closed

Current evaluation

Merged fix for missing built_at upload option. Code now correctly reads snapcraft-started-at from snap/manifest.yaml instead of meta/snap.yaml. Targeted hotfix/7.5 branch for imminent release. Approved and merged with full test coverage.

Suggested action:

No scores available.

Issue body

snapcraft-started-at is a manifest field. This suggests that upload never sent built_at because it was trying to extract it from meta/snap.yaml instead of snap/manifest.yaml. The unused before this change test file test-snap-with-started-at.snap was updated accordingly: - snapcraft-started-at field was removed from meta/snap.yaml, - and a new snap/manifest.yaml was added. The change was tested against the Store. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for missing built_at upload option. Code now correctly reads snapcraft-started-at from snap/manifest.yaml instead of meta/snap.yaml. Targeted hotfix/7.5 branch for imminent release. Approved and merged with full test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged fix for missing built_at upload option. The command now correctly reads snapcraft-started-at from snap/manifest.yaml instead of meta/snap.yaml. Targeted and merged into hotfix/7.5 branch for imminent release.
qwen3.6-35b-a3b-mtp-q6 Merged fix for missing built_at upload option. Code now reads snapcraft-started-at from snap/manifest.yaml instead of meta/snap.yaml. Merged into hotfix/7.5 branch for imminent release with full test coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2559 manifest: expose snapcraft-started-at snapcraft merged Merged to master after approval and passing CI. Exposes snapcraft-started-at in manifest.yaml as an ordering mechanism for Snap Store processing. Codecov noted a minor coverage decrease, but changes were accepted.
70%