extensions: plugin aware part_snippet values
Metadata
Current evaluation
Merged PR #4271 made extension part_snippet values plugin-aware while preserving legacy behavior through an optional base-class API; commit 4c6b1fdc6 closes #4255.
Resolution: closed resolved
Reason: PR #4271 was merged as commit 4c6b1fdc6 after approval, with no unresolved review comments. Its author explicitly noted that it fixed #4255.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Extend the API to take a plugin_name, for legacy do the same, but as an optional method in the base class.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4271 made extension part_snippet values plugin-aware while preserving legacy behavior through an optional base-class API; commit 4c6b1fdc6 closes #4255. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4271 merged as commit 4c6b1fdc6 (2023-07-12): Extension.get_part_snippet now takes a plugin_name keyword arg, applied per part; closes issue #4255. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4271 merged (commit 4c6b1fdc6, 2023-07-12) making extensions plugin aware: get_part_snippet now takes plugin_name, applied per part via _utils.apply_extension. Closes issue #4255. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4271 (commit 4c6b1fdc6) makes extensions part-plugin aware: Extension.get_part_snippet now takes a keyword-only plugin_name, applied from each part's plugin in _utils.apply_extension. Closes #4255. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4271 by sergiusens merged into main as commit 4c6b1fdc6, making Extension.get_part_snippet() plugin-aware (new required plugin_name kwarg applied per-part plugin) while preserving legacy behaviour. Closes issue #4255. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged plugin-aware part_snippet values into main in PR #4271 (commit 4c6b1fdc6), resolving #4255. Extensions now accept an optional plugin_name while legacy behavior remains supported. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Extends the API to accept a plugin_name parameter for plugin-aware part_snippet values. Approved by one reviewer, passed CI, and resolves issue #4255 across 13 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Extends the API to accept a plugin_name for plugin-aware part_snippet values, with legacy support implemented as an optional base class method. Resolves issue #4255. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4255
(confidence 100%)
PR #4271 was identified as the fix for this plugin-awareness issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4255 Make extensions part plugin aware | snapcraft | closed | Extensions became plugin-aware through plugin-specific part_snippet values while preserving legacy behavior. Fixed by merged PR #4271 in commit 4c6b1fdc6. | |
| #4209 extensions: add no_extension entry for parts | snapcraft | closed | PR #4209 proposed a `no_extension` parts entry to opt parts out of extensions. Maintainer sergiusens closed it on 2023-07-12 in favor of #4271 (plugin-aware part_snippet, merged as 4c6b1fdc6). |