← Back to issue list

docs: remove obsolete submodule

View original Github issue

Metadata

Project
snapcraft
Number
#4272
Type
pull request
State
merged
Author
dboddie
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4272 (commit e57f979ed) removed the obsolete sphinx-docs-starter-pack submodule entry from .gitmodules, deleting 3 lines from one docs-related config file.

Resolution: closed resolved

Reason: The PR was approved and merged into snapcraft as commit e57f979ed ("docs: remove obsolete submodule (#4272)"), dropping the stale sphinx-docs-starter-pack submodule stanza from .gitmodules. The maintainer's follow-up comment asked whether other repos had outdated submodules.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4272 (commit e57f979ed) removed the obsolete sphinx-docs-starter-pack submodule entry from .gitmodules, deleting 3 lines from one docs-related config file.
stealth/space-bunny-alpha — closed resolved Merged PR #4272 in commit e57f979ed removed an obsolete submodule entry, deleting three lines from one documentation file.
stealth/space-bunny-alpha — closed resolved Merged #4272 (commit e57f979ed), removing three obsolete .gitmodules lines with no other documentation changes.
qwen/qwen3.6-35b-a3b — — Merged a pull request removing an obsolete documentation submodule. Approved and passing CI, the change deleted three lines from one file. The author suggested auditing other repositories for outdated submodules.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes that removed an obsolete submodule from the documentation. The author recommended auditing other repositories for outdated submodules.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4367 (confidence 55%)

    Later touched the starter pack submodule in .gitmodules ("docs: update sphinx theme"), continuing the cleanup started here.

  • Related To: snapcraft#5798 (confidence 45%)

    Renamed the starter pack submodule much later, showing the entry removed in #4272 was eventually fully retired.

Related issues

Issue Project State Summary Similarity
#713 docs: remove starter pack submodule craft-providers merged Merged docs cleanup PR deleting the leftover sphinx-docs-starter-pack submodule directory (and its .gitmodules entry) left behind after #562 removed the submodule, avoiding pip build errors.
87%
#562 docs: update to canonical-sphinx craft-providers merged Merged PR (commit 9897239) enabled the canonical-sphinx docs extension and removed sphinx-docs-starter-pack submodule references in craft-providers. Leftover submodule dir was later cleaned up in #713.
75%
#325 docs: use canonical-sphinx craft-application merged Merged PR #325 in commit 8ca97e1a, migrating the docs to canonical-sphinx and removing unused extensions and configuration.
73%
#720 docs: use canonical-sphinx craft-parts merged Merged PR #720 as commit 278feb8d, migrating craft-parts docs to canonical-sphinx and removing legacy configuration across three files.
72%
#1341 chore: rename starter pack submodule craft-parts merged Merged in #1341 via 1803cfa8, renaming the documentation submodule to sphinx-docs-starter-pack and updating references and contributor resync instructions.
71%
#1852 docs: remove how-to and tutorial sections charmcraft merged Merged #1852 in commit d2ffef3f, removing 40 lines of how-to and tutorial content from three documentation files and resolving #1836.
70%