← Back to issue list

requirements: bump craft-archives

View original Github issue

Metadata

Project
snapcraft
Number
#4303
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged. Bumps craft-archives to v1.1.3, resolving #4289 and #4298 by fixing architecture handling for package repositories. Ensures dpkg commands only run for compatible host-repo combinations, preventing apt failures.

Suggested action:

No scores available.

Issue body

Version 1.1.3 fixes the issue with package-repositories that declare architectures. In addition to addressing the wrong parameter order, the new version also improves the handling of architectures. The summary of the change is: if the host system is amd64 and the arch of the package repository is i386, _or_ if the host is arm64 and the repo armhf, then `dpkg --add-architecture <repo_arch>` will be called. Otherwise, the command is not called. This lets us preserve the behavior of enabling i386 in the official repositories when a repo using i386 is added, with the improvement of _not breaking_ apt update when an "incompatible" architecture combination is declared. The new spread tests reflect this. Both run in amd64 and add the deadsnakes ppa to fetch Python in a foreign arch: - For i386, only the deadsnakes ppa is necessary, as the architecture will be added "globally" and Python's dependencies are found in the default archives; - For armhf, the ports.ubuntu.com repo is necessary in addition to the deadsnakes one. This lets the dependencies be found in the ports repo, _and_ doesn't break the build (this combination is broken in Snapcraft 7.2, 7.3 and 7.4). Fixes #4289 and #4298

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Bumps craft-archives to v1.1.3, resolving #4289 and #4298 by fixing architecture handling for package repositories. Ensures dpkg commands only run for compatible host-repo combinations, preventing apt failures.
qwen3.6-35b-a3b-mtp-q6 Merged update to craft-archives v1.1.3, fixing architecture handling in package repositories. Updated logic applies dpkg --add-architecture only for compatible host-repo combinations, preventing apt update failures. Resolves #4289 and #4298.
qwen3.6-35b-a3b-mtp-q6 Merged PR bumping craft-archives to v1.1.3 to fix package repository architecture handling. The update corrects parameter ordering and improves dpkg architecture addition logic, resolving issues #4289 and #4298.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4277 requirements: bump craft-archives snapcraft merged Merged into hotfix/7.5 after bumping craft-archives to 1.1.2, restoring local file:// package repository support. Approved by reviewers and passed all CI checks.
83%
#5124 build(deps): bump craft-archives snapcraft merged Merged to bump the craft-archives dependency, resolving LP#2083013 by fixing package-repository conflicts with default sources in Ubuntu Noble. Approved by two reviewers, passed CI, and modified five files.
81%
#4235 requirements: bump craft-archives to fix regression snapcraft closed Merged into hotfix/7.4 to bump craft-archives, resolving regression #4224. The update restores support for asset files containing multiple keys, aligning with the previous apt-key behavior.
77%
#6415 build(deps): bump craft-archives to 2.2.2 snapcraft merged Merged dependency update bumping craft-archives to 2.2.2, resolving issue #6326. Approved by two reviewers and passing most CI checks, the change was integrated into the main branch.
77%
#4079 update craft-archives and support apt pinning snapcraft merged Merged into main after approval and passing CI. Updates craft-archives to v0.0.3, restructures key handling, and adds apt repository pinning support. Resolves CRAFT-1646 with 100% diff coverage.
72%
#4174 requirements: update craft-archives snapcraft merged Merged update to the craft-archives dependency in project requirements. Approved by one reviewer with no unresolved comments. Code coverage remained unchanged upon integration into the main branch.
71%
#276 requirements: update craft-archives rockcraft merged Merged after updating the craft-archives dependency. Approved by two reviewers and passed CI. Comments noted unrelated flaky spread tests linked to an upstream LXD bug, which did not block the merge.
71%