← Back to issue list

requirements: bump craft-archives

View original Github issue

Metadata

Project
snapcraft
Number
#4303
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4303, bumping craft-archives to 1.1.3 to correct dpkg argument ordering and enable only compatible repository architectures; fixes #4289 and #4298.

Resolution: closed resolved

Reason: PR #4303 was merged, with the dependency change recorded in commit 1db0f397b. craft-archives 1.1.3 corrected dpkg argument order and avoided incompatible architecture additions, resolving #4289 and #4298.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Version 1.1.3 fixes the issue with package-repositories that declare architectures. In addition to addressing the wrong parameter order, the new version also improves the handling of architectures. The summary of the change is: if the host system is amd64 and the arch of the package repository is i386, _or_ if the host is arm64 and the repo armhf, then `dpkg --add-architecture <repo_arch>` will be called. Otherwise, the command is not called. This lets us preserve the behavior of enabling i386 in the official repositories when a repo using i386 is added, with the improvement of _not breaking_ apt update when an "incompatible" architecture combination is declared. The new spread tests reflect this. Both run in amd64 and add the deadsnakes ppa to fetch Python in a foreign arch: - For i386, only the deadsnakes ppa is necessary, as the architecture will be added "globally" and Python's dependencies are found in the default archives; - For armhf, the ports.ubuntu.com repo is necessary in addition to the deadsnakes one. This lets the dependencies be found in the ports repo, _and_ doesn't break the build (this combination is broken in Snapcraft 7.2, 7.3 and 7.4). Fixes #4289 and #4298

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4303, bumping craft-archives to 1.1.3 to correct dpkg argument ordering and enable only compatible repository architectures; fixes #4289 and #4298.
stealth/space-bunny-alpha — closed resolved Merged #4303 bumped craft-archives to 1.1.3, fixing dpkg argument order and architecture handling for package repositories and resolving #4289 and #4298.
stealth/space-bunny-alpha — closed resolved Merged #4303, bumping craft-archives to 1.1.3 to correct dpkg argument ordering and enable only compatible repository architectures, fixing #4289 and #4298.
qwen/qwen3.6-35b-a3b — — Merged. Bumps craft-archives to v1.1.3, resolving #4289 and #4298 by fixing architecture handling for package repositories. Ensures dpkg commands only run for compatible host-repo combinations, preventing apt failures.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to craft-archives v1.1.3, fixing architecture handling in package repositories. Updated logic applies dpkg --add-architecture only for compatible host-repo combinations, preventing apt update failures. Resolves #4289 and #4298.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#4277 requirements: bump craft-archives snapcraft merged Merged PR #4277 (commit 7e6e3173, 2023-07-13) bumped craft-archives from 1.1.1 to 1.1.2, restoring support for local package repositories using url: file:///... (craft-archives PR #93).
86%
#4174 requirements: update craft-archives snapcraft merged Merged in #4174 (5134d01e0), then reverted by 8a6872cf7; a corrected craft-archives 1.1.2 upgrade landed in #4277 (7e6e31733).
81%
#5124 build(deps): bump craft-archives snapcraft merged Merged PR #5124 as commit 47c3c2169, bumping craft-archives to fix LP#2083013 package-repository conflicts with Ubuntu Noble default sources.
78%
#4235 requirements: bump craft-archives to fix regression snapcraft closed Merged into hotfix/7.4 at 6d34ebb, bumping craft-archives to restore support for asset files containing multiple GPG keys and fixing #4224.
78%
#96 sources: only add "compatible" architectures craft-archives merged Merged as craft-archives commit 06b1ca2: fixes dpkg --add-architecture argument order and only adds host-compatible archs (amd64→i386, arm64→armhf). Shipped in 1.1.3, whose changelog was added in #97.
74%
#6415 build(deps): bump craft-archives to 2.2.2 snapcraft merged Merged PR #6415 (mr-cal) bumped craft-archives 2.2.1 -> 2.2.2 in snapcraft's dependency pins, fixing #6326 where core26 arm64 builds failed because craft-archives auto-added armhf to the apt architectures list.
74%
#4298 pkg: error: --add-architecture takes exactly one argument snapcraft closed Duplicate of #4289; the underlying dpkg architecture regression was fixed in craft-archives 1.1.3 via PR #96 (commit 06b1ca2).
74%
#276 requirements: update craft-archives rockcraft merged Merged rockcraft#276 in commit 94346ab5, updating craft-archives requirements across three files (+3/-3).
73%
#4289 dpkg --add-architecture fails when using package-repositories snapcraft closed Fixed in craft-archives 1.1.3 via canonical/craft-archives#96 (06b1ca2), reordering dpkg options so --root precedes --add-architecture; rolled out via Snapcraft candidate.
72%
#81 docs: changelog for 1.1.0 craft-archives merged Merged PR #81 (commit 1c354f2), documenting craft-archives 1.1.0; the release added Apt repository support for non-default roots.
70%