← Back to issue list

Please include .*.hmac files by default in stage and prime

View original Github issue

Metadata

Project
snapcraft
Number
#4310
Type
issue
State
open
Author
xnox
Labels
—
Created
Updated
Closed
—

Current evaluation

FIPS kernel HMAC sidecars are omitted by the default stage and prime filesets; this open, unlabelled request has had no maintainer activity.

Suggested action: needs triage

Reason: The report identifies the exact .*.hmac files and required behavior, but provides no executable reproducer; current craft-parts code still defaults both stage_files and prime_files to ["*"], with no hmac-specific handling found. The issue has no labels, maintainer comments, or evidence of a resolving change, so it needs ownership and priority triage rather than closure.

Evaluated by: mr-cal-bot

Impact: 48 Quick Win: 25 Complexity: 24 Confidence: 84 Actionability: 68

Issue body

### Bug Description when staging FIPS builds of packages that include hmac files - i.e. `.vmlinuz-5.15.0-1000-fips.hmac` corresponding to `vmlinuz-5.15.0-1000-fips` file, the `.*.hmac` files are not copied from CRAFT_PART_INSTALL into stage, and not copied from stage to prime. I guess none of the hidden files are currently copied by default (probably good), but `.*.hmac` files should be copied, as otherwise everything is broken. Please ensure that `.*.hmac` are included in the default copy file patterns to stage and to prime. ### To Reproduce n/a ### Environment n/a ### snapcraft.yaml ```yaml override-prime: | cp "$CRAFT_PART_INSTALL"/.kernel.efi-*.hmac "$CRAFT_PRIME"/.kernel.efi.hmac craftctl default ``` ### Relevant log output ```shell n/a ``` ### Additional context _No response_

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 48
Quick Win: 25
Complexity: 24
Confidence: 84
Actionability: 68
needs triage FIPS kernel HMAC sidecars are omitted by the default stage and prime filesets; this open, unlabelled request has had no maintainer activity.
qwen/qwen3.6-35b-a3b
Impact: 70
Quick Win: 29
Complexity: 40
Confidence: 60
Actionability: 70
needs triage Hidden .hmac files are excluded from stage and prime filesets in craft-parts, breaking FIPS builds. Issue filed 1140 days ago with no maintainer response or labels.
qwen/qwen3.8-27b
Impact: 55
Quick Win: 33
Staleness: 75
Complexity: 40
Confidence: 60
Support Request: 10
needs triage Request to include hidden .*.hmac files in default stage/prime copy patterns for FIPS kernel builds; unlabelled, no maintainer response, last activity 536 days ago.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 15
Confidence: 80
Support Request: 10
needs triage Request to include .*.hmac files in default stage and prime copy patterns for FIPS builds. Untriaged, inactive for over a year, no maintainer response.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 15
Confidence: 70
Support Request: 10
close stale Request to include .*.hmac files in default stage and prime copy patterns. Unlabelled, zero maintainer comments, and inactive for over three years.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.