← Back to issue list

fix(legacy): export sources method to local plugins

View original Github issue

Metadata

Project
snapcraft
Number
#4337
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4337 (commit 15011660a) adds a legacy sources export so local plugins importing snapcraft.sources.get are redirected to snapcraft_legacy; shipped in Snapcraft 7.5.3 and fixes #4285.

Resolution: closed resolved

Reason: The PR was merged into main as commit 15011660a ("fix(legacy): export sources method to local plugins (#4337)", +85 lines across 5 files) and was also merged into the hotfix/7.5 branch (PR head 6fc46f2). It explicitly states "Fixes #4285"; the linked issue #4285 closed with confirmation that the nextcloud-snap build succeeded on 7.5.3.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Support legacy local plugins that invoke `snapcraft.sources.get` by redirecting imports to `snapcraft_legacy`. This is similar to the strategy used for V1 and V2 plugins. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Fixes #4285

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4337 (commit 15011660a) adds a legacy sources export so local plugins importing snapcraft.sources.get are redirected to snapcraft_legacy; shipped in Snapcraft 7.5.3 and fixes #4285.
stealth/space-bunny-alpha — closed resolved Merged #4337 into hotfix/7.5, redirecting legacy local-plugin imports so snapcraft.sources.get is exported. Commit 15011660a fixes #4285, resolved in v7.5.3.
stealth/space-bunny-alpha — closed resolved Merged PR #4337 into hotfix/7.5, redirecting local-plugin snapcraft.sources imports to snapcraft_legacy. Restored core18 builds and shipped in Snapcraft 7.5.3, fixing #4285.
qwen/qwen3.6-35b-a3b — — Merged to hotfix/7.5, resolving #4285 by redirecting local plugin imports to snapcraft_legacy to export the sources method. Approved by three reviewers, passed CI, and achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.5 to resolve #4285. Redirects snapcraft.sources.get imports to snapcraft_legacy, enabling legacy local plugin support. Achieved 100% diff coverage. An unrelated Flutter core18 spread test crash occurred during CI.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#4285 (confidence 95%)

    Issue #4285 ("Snapcraft v7 fails to build core18 snap with local plugins") is the bug fixed by this PR, per its "Fixes #4285" line; issue closed noting the fix in 7.5.3.

  • Related To: snapcraft#4285 (confidence 80%)

    Resolution verified via commit 15011660a adding the legacy sources export/redirect (similar to existing V1/V2 plugin import redirection strategy).

Related issues

Issue Project State Summary Similarity
#4285 Snapcraft v7 fails to build core18 snap with local plugins snapcraft closed Snapcraft 7 broke core18 snaps with local plugins (module 'snapcraft' has no attribute 'sources'). Fixed by merged PR #4337 (commit 15011660a) exporting sources to legacy plugins; reporter confirmed success on 7.5.3.
75%