Remove global state attributes from snapcraft.common
Metadata
Current evaluation
Merged PR #434 (commit 3343e5c6b) removing global state attributes from snapcraft.common, replacing module-level constants with project options; follow-up PR #445 (8f601c0ca) moved common dirs to ProjectOptions.
Resolution: closed resolved
Reason: The PR was merged into snapcraft's mainline as commit 3343e5c6b, which appears in the history of snapcraft/common.py and removes the module-level global state in favour of project-scoped options, with 51 files changed (+682/-547). Maintainer sergiusens and reviewer kyrofa approved ('Looks great!') before merge.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #434 (commit 3343e5c6b) removing global state attributes from snapcraft.common, replacing module-level constants with project options; follow-up PR #445 (8f601c0ca) moved common dirs to ProjectOptions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #434, commit 3343e5c6b, removed global state attributes from snapcraft.common and updated the surrounding codebase and tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to remove global state attributes from snapcraft.common. Author sergiusens discussed extending the refactor to additional functions before final approval and merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after maintainer sergiusens removed global state attributes from snapcraft.common. Reviewer kyrofa requested a title correction, approved the changes, and the pull request was merged. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#445
(confidence 88%)
Immediate follow-up merged PR (commit 8f601c0ca) that moved the common directories from snapcraft.common into ProjectOptions, directly continuing this refactor.
-
Related To:
canonical/snapcraft#433
(confidence 45%)
Preceding commit af86cddce 'Converge all commands into one' that this refactor builds on; snapcraft.common globals were being consolidated ahead of that work.
Related issues
No related issues found above the similarity threshold.