feat(remote-build): check if project is in a git repository
Metadata
Current evaluation
Merged PR #4370 added Git-repository detection for remote-build, preserving legacy behavior for non-Git projects; commit e0ef5ec27 resolves #4321.
Resolution: closed resolved
Reason: PR #4370 was merged after approval, landing commit e0ef5ec27. It routes Git-hosted projects through the new remote-build path while retaining the legacy path for non-Git projects, resolving #4321.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
This is the last bit of control logic for remote-build.
If a snapcraft project is not in a git repository, execute the legacy remote-build code.
Fixes #4321
(CRAFT-1976)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4370 added Git-repository detection for remote-build, preserving legacy behavior for non-Git projects; commit e0ef5ec27 resolves #4321. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4370 merged (commit e0ef5ec27), adding Git-repo detection to remote-build: Git projects use the new implementation, non-Git projects fall back to legacy remote-build. Fixes #4321 (CRAFT-1976). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4370 added Git-repository detection for remote-build, falling back to legacy remote-build logic for non-Git projects and fixing #4321. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged feature adding git repository detection for remote-build. Falls back to legacy remote-build logic when a project lacks a git repository, resolving issue #4321. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged adds git repository detection to remote-build logic, falling back to legacy execution when absent. Resolves #4321 by finalizing remote build control flow. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4321
(confidence 100%)
PR #4370 explicitly fixes this issue by adding Git-repository detection and dispatch logic.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #310 fix(remote-build): enable git repo check | craft-application | merged | Merged PR #310 in commit 28429b84, enabling remote builds to check Git cleanliness before staging and committing copied project changes. | |
| #4321 remote-build: add control logic when the project is in a git repo | snapcraft | closed | Commit e0ef5ec27 added Git-aware remote-build dispatch: Git projects use the new implementation, while non-Git projects retain the legacy path. | |
| #4368 feat(remote-build): add GitRepo class | snapcraft | merged | Merged PR #4368 as dc58181e8, adding a pygit2-based GitRepo wrapper for remote builds and resolving #4320 (CRAFT-1975). | |
| #293 feat(remote-build): allow a user-provided project | craft-application | merged | Added support for user-provided projects in remote builds, resolving #274; PR #293 merged as commit 8d50bcc8. |