← Back to issue list

feat(remote-build): check if project is in a git repository

View original Github issue

Metadata

Project
snapcraft
Number
#4370
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged feature adding git repository detection for remote-build. Falls back to legacy remote-build logic when a project lacks a git repository, resolving issue #4321. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- This is the last bit of control logic for remote-build. If a snapcraft project is not in a git repository, execute the legacy remote-build code. Fixes #4321 (CRAFT-1976)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged feature adding git repository detection for remote-build. Falls back to legacy remote-build logic when a project lacks a git repository, resolving issue #4321. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged adds git repository detection to remote-build logic, falling back to legacy execution when absent. Resolves #4321 by finalizing remote build control flow.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds git repository validation to remote-build control flow, falling back to legacy execution when absent. Resolves #4321.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4368 feat(remote-build): add GitRepo class snapcraft merged Merged into main, introducing a GitRepo class for remote builds to resolve #4320. Approved by two reviewers with passing CI and 100% diff coverage. An unrelated spread failure was noted for later investigation.
78%
#310 fix(remote-build): enable git repo check craft-application merged Successfully merged the fix enabling the git repository check for remote builds. Approved by two reviewers, the update modifies two files with 18 additions and 1 deletion, resolving the build configuration issue.
74%
#4395 feat(remote-build): new command logic snapcraft merged Merged into main. Introduces a RemoteBuild class to orchestrate remote builds, adds local project directory caching, and implements post-build cache cleanup. Resolves #4324. Approved by three reviewers with passing CI and 97.88% diff coverage.
73%
#1546 feat: remote build command charmcraft merged Merged the remote build command feature. Approved by two reviewers and passing CI, the PR rebases prior work and adds remote build functionality. Follow-up issues were created to resolve related build-id recovery and dependency bugs.
72%
#4385 feat(remote-build): get build id snapcraft merged Merged implementation for remote build ID generation or command-line acceptance, resolving issue #4322. Approved by reviewers, passed CI, and adds logic to handle build IDs automatically or via input.
71%