chore(deps): add pygit to doc requirements
Metadata
Current evaluation
Merged #4375 as e340be1ce, adding pygit2 to documentation requirements and restoring Sphinx builds broken by #4368.
Resolution: closed resolved
Reason: PR #4375 was merged in commit e340be1ce, adding the missing pygit2 dependency needed to import the GitRepo code introduced by #4368 during documentation builds.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
#4368 broke sphinx:
```
python -m sphinx -T -E -W --keep-going -b html -d _build/doctrees -D language=en . $READTHEDOCS_OUTPUT/html
Running Sphinx v7.2.6
making output directory... done
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/gen_cli_docs.py", line 13, in <module>
from snapcraft import cli
File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/cli.py", line 37, in <module>
from . import commands
File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/commands/__init__.py", line 63, in <module>
from .remote import RemoteBuildCommand
File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/commands/remote.py", line 33, in <module>
from snapcraft.remote import is_repo
File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/remote/__init__.py", line 20, in <module>
from .git import GitRepo, is_repo
File "/home/docs/checkouts/readthedocs.org/user_builds/canonical-snapcraft/checkouts/latest/tools/docs/../../snapcraft/remote/git.py", line 22, in <module>
import pygit2
ModuleNotFoundError: No module named 'pygit2'
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4375 as e340be1ce, adding pygit2 to documentation requirements and restoring Sphinx builds broken by #4368. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4375 (e340be1ce), adding pygit2 to documentation requirements to restore Sphinx builds broken by #4368. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as e340be1ce, adding pygit2 to documentation requirements and restoring Sphinx builds broken by #4368. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4375 as e340be1ce, adding pygit2 to documentation requirements to restore Sphinx builds broken by #4368. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4375 (e340be1ce), adding pygit2 to documentation requirements to restore Sphinx builds broken by #4368. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to add pygit to documentation requirements, fixing a Sphinx build failure from a missing pygit2 module. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a Sphinx documentation build failure caused by a missing pygit2 dependency. Added pygit2 to doc requirements to resolve the ModuleNotFoundError introduced in PR #4368. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/snapcraft#4368
(confidence 100%)
Its new GitRepo import required pygit2, which was absent from the documentation environment and broke Sphinx.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #548 chore(deps): update documentation dependencies (major) | craft-parts | merged | Merged into main in commit cd3a0078, updating Sphinx 5.3.0 to 7.2.6 and furo 2022.12.7 to 2023.9.10. | |
| #368 chore(deps): update documentation dependencies | craft-providers | merged | Renovate dependency bump PR merged as commit 5eae8d4 (2023-07-28): docs/sphinx-lint 0.6.7→0.6.8 and docs/sphinx-toolbox 3.4.0→3.5.0, +2/-2 lines in the docs requirements. | |
| #4473 chore(deps): update bugfixes | snapcraft | merged | Merged via #4473 in commit 662af4c00, updating eight pinned Python dependencies to newer bugfix releases, including pydantic 1.10.13, psutil 5.9.6, and pygit2 1.13.3. | |
| #538 chore(deps): update documentation dependencies (major) | rockcraft | merged | Merged PR #538 in commit b007f265, upgrading Sphinx to 7.3.7 and sphinx-autodoc-typehints to 2.1.0. | |
| #409 chore(deps): update documentation dependencies | craft-providers | merged | Merged in #409 (f74d18a), updating Furo to 2023.9.10 and Sphinx from 7.1.x to 7.2.x. | |
| #160 chore(deps): update documentation dependencies | craft-store | merged | Merged documentation dependency updates: pyspelling 2.9→2.10 and sphinx-tabs 3.4.4→3.4.5, via PR #160 at commit 253cae4. | |
| #147 chore(deps): update documentation dependencies | craft-store | merged | Merged #147, updating lxd-sphinx-extensions to 0.0.16 and both sphinx-lint and sphinxext-opengraph to 0.9.1. | |
| #520 chore(deps): update documentation dependencies | craft-providers | merged | Merged PR #520 as commit 1bac247, updating pyspelling to 2.10 and both documentation/root sphinx-tabs pins to 3.4.5. | |
| #485 chore(deps): update documentation dependencies | craft-providers | merged | Renovate chore(deps) PR bumping docs deps (lxd-sphinx-extensions 0.0.15→0.0.16, sphinx-lint 0.9.0→0.9.1) was merged into main as commit e007b86, changing pyproject.toml and docs/sphinx-lint lock/config pins. | |
| #72 chore(deps): update documentation dependencies | craft-application | merged | Merged PR #72, updating furo to 2023.7.26 and sphinx-design, sphinx-lint, and sphinx-toolbox to 0.5.0, 0.6.8, and 3.5.0. |