← Back to issue list

ci: download snap to tests dir

View original Github issue

Metadata

Project
snapcraft
Number
#4380
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4380 as commit 0de1f0e1d, fixing scheduled Spread tests to download the snap into the tests/ directory.

Resolution: closed resolved

Reason: PR #4380 was approved and merged as commit 0de1f0e1d. The author verified the change with scheduled run 6313456368.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- The scheduled spread tests were not downloading the snap to the `tests/` directory. I triggered a run and it is working now. See logs here: https://github.com/snapcore/snapcraft/actions/runs/6313456368

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4380 as commit 0de1f0e1d, fixing scheduled Spread tests to download the snap into the tests/ directory.
stealth/space-bunny-alpha — closed resolved Merged PR #4380 as commit 0de1f0e1d, fixing scheduled Spread tests to download the snap into tests/; a triggered test run confirmed the change worked.
qwen/qwen3.6-35b-a3b — — Merged a CI fix that ensures scheduled spread tests download the snap to the tests directory. Approved by two reviewers, passed CI checks, and modified one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Resolved CI spread test failures by ensuring the snap downloads to the tests directory. Verified working via CI logs.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#432 ci: speed up spread testing workflow fetch-service merged Merged PR #432 (commit 9eec284), removing snap-test's dependency on snap-build so spread tests start sooner while snap-build still produces downloadable artifacts.
79%
#521 test(spread): add an improved snap inspector test fetch-service merged Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests.
74%
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap.
73%
#1068 tests: use a temporary directory for snaps tests snapcraft merged Merged PR #1068 made snaps tests use a temporary directory, fixing Launchpad bug #1643658; landed as commit 1d4e5878d.
72%
#3476 ci: reduce amount of artifacts to upload for spread snapcraft merged Merged #3476 (f6fb10359), reducing Spread uploads to tests/ while preserving reset behavior; local runs now require the tested snap in that directory.
72%
#5841 Include "build snapd snap" test in test suite snapcraft closed Added spread coverage for building snapd and base snaps in merged PR #5845 (commit fb8c81e8f).
71%
#1259 tests: use launchpad as the source of the compressed test snap snapcraft merged Merged PR #1259 via commit 2409c9eec, switching the compressed test-snap source used by tests to Launchpad.
71%
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
71%
#5845 test(spread): test building base and snapd snaps snapcraft merged Merged as fb8c81e8f, adding manual Spread coverage that builds current base snaps and the snapd snap against mainline Snapcraft.
71%
#3091 ci: install the snapd snap when preparing spread systems snapcraft merged Merged PR #3091, updating Spread setup to install the snapd snap when preparing CI systems.
71%