← Back to issue list

feat(cli): add craft-application scaffolding

View original Github issue

Metadata

Project
snapcraft
Number
#4456
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4456 added craft-application Project/Application scaffolding and ClassicFallback CLI routing; initial support was integrated by #4560 at commit 98550856e.

Resolution: closed resolved

Reason: PR #4456 was merged, adding the Project model, Application class, and CLI fallback to existing Snapcraft commands. The repository identifies merged PR #4560 and commit 98550856e as the integration of this initial support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Adds `craft-application` scaffolding to snapcraft. This includes migrating to the `Project` model, adding an `Application` class, and CLI handling. All commands are unimplemented, raise a `ClassicFallback` error, and execute the existing snapcraft code. This has the same scope and intent as https://github.com/canonical/rockcraft/pull/353. This is based on @lengau's work in https://github.com/snapcore/snapcraft/pull/4449, which includes this work and more (such as the implementation of lifecycle commands). (CRAFT-2238)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4456 added craft-application Project/Application scaffolding and ClassicFallback CLI routing; initial support was integrated by #4560 at commit 98550856e.
stealth/space-bunny-alpha — closed resolved Merged through #4560 as 98550856e, adding initial craft-application support with Project/Application models and CLI fallback to existing Snapcraft logic.
stealth/space-bunny-alpha — closed resolved Merged craft-application scaffolding in #4560 (commit 98550856e), adding Project/Application models and CLI fallback to existing Snapcraft commands.
stealth/space-bunny-alpha — closed resolved Merged craft-application scaffolding into the feature branch, adding the Project model, Application class, and CLI handling with ClassicFallback to existing snapcraft commands.
qwen/qwen3.6-35b-a3b — — Merged. Adds craft-application scaffolding to snapcraft, migrating to the Project model and adding an Application class and CLI. Commands raise ClassicFallback to run existing code. Merged despite a flaky Appveyor test.
qwen3.6-35b-a3b-mtp-q6 — — Merged craft-application scaffolding into snapcraft, adding the Project model, Application class, and CLI handling. Commands fallback to existing behavior. Merged despite a flaky Appveyor test, as it passed on the branch and targets a feature branch.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4449 (confidence 99%)

    Starter and broader implementation on which #4456 was based; it also included lifecycle commands.

  • Likely Fixed By: canonical/snapcraft#4560 (confidence 98%)

    Merged the initial craft-application support in commit 98550856e.

  • Related To: canonical/rockcraft#353 (confidence 95%)

    Parallel work with the same scope and intent.

Related issues

Issue Project State Summary Similarity
#353 refactor(cli): add scaffolding for craft-application rockcraft merged PR #353 merged into feature/craft-application as 5cff2f1c, adding craft-application scaffolding with a legacy-runner fallback.
82%
#4449 [WIP] feat: craft-application basic scaffolding snapcraft closed Closed unmerged as WIP; initial Craft Application support later landed via #4560 (commit 98550856e).
73%
#4560 feat(craft-application): initial support snapcraft merged Merged PR #4560 as 98550856e, adding initial craft-application support with fallback to Snapcraft's existing logic.
72%