← Back to issue list

fix: push tags for remote-build

View original Github issue

Metadata

Project
snapcraft
Number
#4460
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after approval from two reviewers. The fix enables pushing tags for remote-build, maintaining 89.18% overall test coverage with 100% on modified lines. Changes span four files, adding 57 lines and removing 5.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval from two reviewers. The fix enables pushing tags for remote-build, maintaining 89.18% overall test coverage with 100% on modified lines. Changes span four files, adding 57 lines and removing 5.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to push tags for remote builds. The change passed code coverage checks and was integrated into the main branch, resolving the remote-build tag synchronization issue.
qwen3.6-35b-a3b-mtp-q6 Merged to fix remote build tagging. The change ensures tags are pushed correctly, passed code coverage checks, and was approved by the maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#384 fix(remotebuild): push git tags to launchpad craft-application merged Merged a fix that pushes git tags to Launchpad, enabling applications to derive versions from tags. Approved by two reviewers, passed CI checks, and applied with minimal changes across two files.
78%
#769 feat: add the remote-build command rockcraft merged Merged the remote-build command. Approved by three reviewers, the change adds 86 lines and removes 7 across nine files. Integrated by the maintainer without further comments or CI issues.
76%
#310 fix(remote-build): enable git repo check craft-application merged Successfully merged the fix enabling the git repository check for remote builds. Approved by two reviewers, the update modifies two files with 18 additions and 1 deletion, resolving the build configuration issue.
75%
#4384 refactor(remote-build): reorganize functions snapcraft merged Merged a two-commit refactor reorganizing remote-build functions to prepare for issue #4322. Approved by two reviewers, passed CI checks, and modified two files with a net reduction of 40 lines.
72%
#2634 remote build: fully preserve local sources and support packaging all sources snapcraft merged Merged into remote-build. Preserves local sources and enables packaging all sources. Modified 13 files (+673/-528). Iterative updates addressed review feedback, fixed tests, resolved Git import issues, and updated dependencies. Approved by one reviewer.
72%
#4480 fix(remote): return error when remote build failed snapcraft merged Successfully merged fix for remote build failures that returns proper errors, resolving issue #4142. Approved by three reviewers with maintained code coverage across 13 files.
72%
#2642 remote-build: detect early build errors snapcraft merged Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied.
71%
#1632 ci: move remote-build tests to weekly job charmcraft merged Relocated remote-build tests to a weekly CI job. The change modifies two files, removing 32 lines and adding 7. Approved by two reviewers and successfully merged.
70%
#4660 refactor(test): versioned remote-build tests snapcraft merged Merged test refactoring for versioned remote-build tests with no logic changes. Approved by two reviewers, zero unresolved comments, and passing CI. Codecov confirmed full coverage on modified lines. Successfully integrated.
70%
#2564 remote_build: handle git push in detached head state snapcraft merged Merged fix for remote_build that resolves a detached HEAD exception by returning HEAD instead of failing branch name retrieval. Approved by reviewer and passed CI checks.
70%