← Back to issue list

Detect dirty pull step.

View original Github issue

Metadata

Project
snapcraft
Number
#448
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged dirty pull-step detection in snapcraft#448 (commit da1411df0), completing LP #1477904 by flagging pull-related YAML changes for explicit cleaning.

Resolution: closed resolved

Reason: The pull step now detects changes to plugin-associated YAML and errors until explicitly cleaned. The change was merged as commit da1411df0.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently Snapcraft notices YAML changes for every step except the pull step.This PR finishes up LP: [#1477904](https://bugs.launchpad.net/snapcraft/+bug/1477904) by adding this functionality for the pull step, where now if one changes any part of the YAML that the part's plugin says is associated with pulling, pull will notice that it's out of date and error out asking the user to clean the pull step to continue. The pull step is not automatically cleaned like the strip and stage steps because pulls can take a very long time (and require network) and we don't want to blow one away without the user explicitly asking to do so.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged dirty pull-step detection in snapcraft#448 (commit da1411df0), completing LP #1477904 by flagging pull-related YAML changes for explicit cleaning.
stealth/space-bunny-alpha — closed resolved Merged PR #448 (commit da1411df0) added pull-step dirty detection, completing LP #1477904; plugin-relevant YAML changes now require users to clean the pull step.
qwen/qwen3.6-35b-a3b — — Merged changes add dirty detection for the pull step in Snapcraft, resolving Launchpad bug #1477904. The update errors on YAML changes, requiring manual cleanup instead of automatic removal. Approved by sergiusens.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds dirty state detection for the pull step in Snapcraft, erroring on associated YAML changes. Manual cleanup is enforced over auto-cleaning to protect long-running network pulls. Approved and merged by maintainers.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1647877 The pull step is not marked as dirty when the source of the dump plugin is changed snapcraft (launchpad) closed Local-source dirty tracking was added in canonical/snapcraft#2167, commit 39c4c39f1, resolving missed rebuilds after files changed under `.`.
77%
#447 Detect dirty build step. snapcraft merged Merged PR #447 (commit 6224553ae): build step now detects YAML changes affecting a part's plugin build attributes and errors asking the user to clean, advancing LP bug #1477904. Unlike strip/stage, build is not auto-cleaned.
75%
#442 Automatically re-strip if dirty. snapcraft merged Merged PR #442 (commit 1a6a21831): Snapcraft now detects YAML `snap` keyword changes and automatically cleans and re-runs the strip step instead of halting, advancing LP #1477904.
72%