Detect dirty pull step.
Metadata
Current evaluation
Merged changes add dirty detection for the pull step in Snapcraft, resolving Launchpad bug #1477904. The update errors on YAML changes, requiring manual cleanup instead of automatic removal. Approved by sergiusens.
Suggested action: —
No scores available.
Issue body
Currently Snapcraft notices YAML changes for every step except the pull step.This PR finishes up LP: [#1477904](https://bugs.launchpad.net/snapcraft/+bug/1477904) by adding this functionality for the pull step, where now if one changes any part of the YAML that the part's plugin says is associated with pulling, pull will notice that it's out of date and error out asking the user to clean the pull step to continue.
The pull step is not automatically cleaned like the strip and stage steps because pulls can take a very long time (and require network) and we don't want to blow one away without the user explicitly asking to do so.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes add dirty detection for the pull step in Snapcraft, resolving Launchpad bug #1477904. The update errors on YAML changes, requiring manual cleanup instead of automatic removal. Approved by sergiusens. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds dirty state detection for the pull step in Snapcraft, erroring on associated YAML changes. Manual cleanup is enforced over auto-cleaning to protect long-running network pulls. Approved and merged by maintainers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged PR adds dirty detection for the pull step in Snapcraft. It now errors on YAML changes affecting the pull phase, prompting manual cleanup rather than automatic rebuilding. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #447 Detect dirty build step. | snapcraft | merged | Merged. Adds dirty build step detection to Snapcraft, prompting manual cleanup when YAML changes affect the build step. Addresses LP #1477904. Auto-rebuilds were omitted to prevent wasting time on long builds. Approved by sergiusens. | |
| #443 Automatically re-stage if dirty. | snapcraft | merged | Merged PR automatically re-stages and strips Snapcraft steps upon YAML changes, resolving Launchpad bug #1477904. The update modifies six files to detect out-of-date configurations and trigger a clean re-run. | |
| #442 Automatically re-strip if dirty. | snapcraft | merged | Merged. Automatically re-runs the strip step when the snapcraft.yaml snap keyword changes. Detects dirty state via YAML property comparison, cleans, and re-executes. Resolves Launchpad bug #1477904. Documentation added during review. | |
| #2167 many: detect local source changes | snapcraft | merged | Merged. Resolves LP: #1583718 by comparing local source timestamps to pull state. Snapcraft now automatically triggers re-pulling and subsequent steps on local changes, removing manual cleaning. Approved and merged after test fixes. |