extensions/desktop: don't preload bindtextdomain for wine snaps
Metadata
Current evaluation
Merged #4501 as commit 58964d874, preventing the desktop extension from preloading gnome-platform bindtextdomain for Wine snaps.
Resolution: closed resolved
Reason: The approved one-line change was merged as 58964d874, adding a Wine default-provider guard that resolves the remaining case not addressed by #3738.
Evaluated by: mr-cal-bot
No scores available.
Issue body
fixes that #3738 couldn't
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4501 as commit 58964d874, preventing the desktop extension from preloading gnome-platform bindtextdomain for Wine snaps. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 58964d874: a one-line guard now skips gnome-platform bindtextdomain preloading for Wine snaps, fixing the case missed by #3738. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line desktop extension update preventing bindtextdomain preloading for Wine snaps. Approved by three reviewers, passed CI, and resolves a limitation from issue #3738. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to prevent preloading bindtextdomain for Wine snaps in the desktop extension, resolving a limitation PR #3738 could not address. The change was integrated into main despite minor code coverage warnings flagged by Codecov. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#3738
(confidence 98%)
Earlier merged change 1ad71aaff prioritized the snap's bindtextdomain library; #4501 explicitly covers the Wine case it could not resolve.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3738 extensions/desktop: preload bindtextdomain from snap first if it exists | snapcraft | merged | Merged #3738 via commit 1ad71aaff: desktop-launch now prefers the snap's bindtextdomain.so, avoiding architecture-mismatched LD_PRELOAD errors. | |
| #3569 extensions: preload bindtextdomain from content snap if it exists | snapcraft | merged | Merged #3569 via ec318b179, preloading bindtextdomain from the GNOME content snap when present; validated on edge/pr-3569. |