← Back to issue list

fix: warning unsafe override-prime

View original Github issue

Metadata

Project
snapcraft
Number
#4553
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4553 in commit 4a3a0622b added a warning that enable-patchelf cannot process files primed by parts using override-prime.

Resolution: closed resolved

Reason: The approved PR was merged as commit 4a3a0622b and released in Snapcraft 8.0.3. It resolves #4547 by warning users that combining enable-patchelf with override-prime leaves primed files unpatched.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4553 in commit 4a3a0622b added a warning that enable-patchelf cannot process files primed by parts using override-prime.
stealth/space-bunny-alpha — closed resolved Merged #4553 as commit 4a3a0622b, warning that enable-patchelf cannot apply to files primed by parts using override-prime.
qwen/qwen3.6-35b-a3b — — Merged to resolve the unsafe override-prime warning. Approved by two reviewers, the changes add 80 lines across two files. A force push re-targeted the branch to a hotfix release.
qwen3.6-35b-a3b-mtp-q6 — — Merged to address the unsafe override-prime warning. The author force-pushed to re-target the branch to a hotfix, and the change passed Codecov coverage checks before final merge.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#4547 (confidence 100%)

    This PR implemented the requested warning for unsafe enable-patchelf and override-prime combinations.

Related issues

Issue Project State Summary Similarity
#4547 Warn when using `override-prime` and `enable-patchelf` snapcraft closed Warning added for enable-patchelf combined with override-prime, which can leave binaries unpatched. Fixed by merged PR #4553 (commit 4a3a0622b), shipped in Snapcraft 8.0.3.
78%
#1642 fix: warning deprecated prime use charmcraft merged Merged PR #1642 as commit 207a9176, adding a warning for deprecated prime use and fixing charmcraft#1609.
70%