← Back to issue list

feat(projects): validate component names do not begin with 'snap-'

View original Github issue

Metadata

Project
snapcraft
Number
#4566
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4566 to reject component names beginning with the snapd-reserved "snap-" prefix, fixing #4538; #4567 and #4568 addressed unrelated CI failures.

Resolution: closed resolved

Reason: PR #4566 merged after approval from two reviewers and explicitly states that it fixes #4538. The change validates and rejects component names using the prefix reserved for snapd.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Components beginning with `snap-` are reserved for future use by `snapd`. Fixes #4538 (CRAFT-2419)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4566 to reject component names beginning with the snapd-reserved "snap-" prefix, fixing #4538; #4567 and #4568 addressed unrelated CI failures.
stealth/space-bunny-alpha — closed resolved Merged PR #4566 added validation rejecting component names beginning with snap-, reserving that prefix for snapd, and fixes #4538.
stealth/space-bunny-alpha — closed resolved Merged PR #4566, adding validation that rejects component names beginning with “snap-”, which are reserved for snapd; closes #4538.
qwen/qwen3.6-35b-a3b — — Merged validation preventing component names from starting with 'snap-', reserved for snapd. Approved by two reviewers, passed CI, and resolves #4538. Unrelated CI failures were addressed in separate PRs.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Implements validation to reject component names starting with 'snap-', reserving the prefix for snapd. Resolves #4538. Tests passed with full coverage; unrelated CI failures were addressed in separate PRs.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#4538 (confidence 100%)

    The validation request closed by this merged PR.

  • Related To: snapcore/snapcraft#4567 (confidence 98%)

    Merged follow-up that updated lint tooling to resolve an unrelated linter failure.

  • Related To: snapcore/snapcraft#4568 (confidence 98%)

    Merged follow-up that upgraded Chisel to resolve an unrelated Spread failure.

Related issues

Issue Project State Summary Similarity
#4538 Validate component names do not begin with `snap-` snapcraft closed Merged PR #4566 added validation rejecting snapcraft.yaml component names beginning with the snapd-reserved prefix "snap-".
83%
#2069783 cannot create components with digits in the name snapcraft (launchpad) closed Bug confirmed: component names rejected digits, though snapd allows them. Fixed by PR canonical/snapcraft#4945 (commit 8ab7fd0c8) sharing one validator for snap and component names, after upstream craft-parts#790 (b2128938).
74%