fix(package): use correct target-arch on snap
Metadata
Current evaluation
Merged PR #4596 corrected Package service target architecture for snap builds and updated lifecycle, unit, and spread tests; landed as c68b3621c.
Resolution: closed resolved
Reason: The PR was approved and merged into Snapcraft as commit c68b3621c, fixing selection of the correct build-for architecture.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR does a few things, over 3 commits:
- Bring the existing tests inline with the corresponding craft-application changes (where the Lifecycle service now takes a build plan)
- Fix an issue with the wrong build-for in the Package service
- Update the related spread tests. Some are now passing, some are still failing from lack of SNAPCRAFT_BUILD_FOR and some are removed because we won't support those features in core24.
Leaving as a Draft until the craft-application dependency is merged.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4596 corrected Package service target architecture for snap builds and updated lifecycle, unit, and spread tests; landed as c68b3621c. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4596, fixing Package service to use the correct target architecture for snap builds and updating lifecycle, unit, and spread tests; landed as c68b3621c. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval. Fixes incorrect target-arch in the Package service, aligns tests with craft-application updates, and updates spread tests. 14 files changed, +61/-50 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged. Fixed incorrect target architecture in the Package service for snap builds, aligned tests with craft-application updates, and updated spread tests. Passed all code coverage checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1378 Integration tests for snap command with target arch | snapcraft | merged | PR #1378 merged as 18a767537, fixing --target-arch parsing before the snap subcommand and adding integration tests for invocation forms. | |
| #1655797 Set arch for stage packages | snapcraft (launchpad) | closed | Fixed architecture qualifiers such as i386 in stage packages via snapcore/snapcraft PR #1050. |