fix(package): use correct target-arch on snap
Metadata
Current evaluation
Merged following approval. Fixes incorrect target-arch in the Package service, aligns tests with craft-application updates, and updates spread tests. 14 files changed, +61/-50 lines.
Suggested action: —
No scores available.
Issue body
This PR does a few things, over 3 commits:
- Bring the existing tests inline with the corresponding craft-application changes (where the Lifecycle service now takes a build plan)
- Fix an issue with the wrong build-for in the Package service
- Update the related spread tests. Some are now passing, some are still failing from lack of SNAPCRAFT_BUILD_FOR and some are removed because we won't support those features in core24.
Leaving as a Draft until the craft-application dependency is merged.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval. Fixes incorrect target-arch in the Package service, aligns tests with craft-application updates, and updates spread tests. 14 files changed, +61/-50 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged. Fixed incorrect target architecture in the Package service for snap builds, aligned tests with craft-application updates, and updated spread tests. Passed all code coverage checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after correcting the target-arch in the Package service and aligning tests with craft-application updates. Spread tests were updated, and code coverage passed at 89.11%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #314 Replace dpkg-architecure calls in tests | snapcraft | merged | Merged changes replacing dpkg-architecture calls in tests with snapcraft.common imports to improve dependency detection in snapcraft.yaml. Approved by maintainers after resolving a minor import style discussion. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| #557 build: fix snap build in non-amd64 archs | rockcraft | merged | Merged fix for snap builds on non-amd64 architectures, resolving missing dependency wheels. Approved by two reviewers, passed CI, and updated one file with 15 lines. | |
| #1378 Integration tests for snap command with target arch | snapcraft | merged | Merged. Adds integration tests for the snap command with --target-arch, fixing silent flag ignoring when placed before the snap subcommand and missing help text. Approved by two reviewers, four files changed. | |
| #4 snap: introduce initial snap packaging (CRAFT-578) | rockcraft | merged | Merged initial snap packaging implementation (CRAFT-578). Approved by one reviewer, passed CI checks, and added 86 lines across three files. | |
| #5529 fix: remove test artifact workaround | snapcraft | merged | Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files. | |
| #3057 repo: format $SNAPCRAFT_APT_RELEASE instead of ${release} for suites | snapcraft | merged | Merged updates to the repository schema, replacing ${release} with $SNAPCRAFT_APT_RELEASE for suites. Also changes $host_arch to $SNAPCRAFT_APT_HOST_ARCH, though unimplemented. Approved by one reviewer and merged. | |
| #2126 packaging: load the correct libraries on armhf | snapcraft | merged | Merged fix to snapcraft packaging to correctly load armhf libraries via ctypes dlopen, resolving architecture-specific runtime issues. Approved by reviewer and passed CI checks. | |
| #2014 integration tests: snap tests shouldn't be arch-specific | snapcraft | merged | Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file. | |
| #49 packages: add snap package support | craft-parts | merged | Merged after implementing snap download and installation for stage and build snaps. Approved by two reviewers, passed CI, and added 1,072 lines across five files. Follows snapcraft conventions with future refactoring planned. |