← Back to issue list

add SNAP_LIBRARY_PATH

View original Github issue

Metadata

Project
snapcraft
Number
#460
Type
pull request
State
closed
Author
mvo5
Labels
—
Created
Updated
Closed

Current evaluation

PR #460 (mvo5, one-line SNAP_LIBRARY_PATH addition) was closed unmerged by kyrofa in favour of #462, which made the same change plus test fixes and was merged as commit a983e470b.

Resolution: closed superseded

Reason: Maintainer kyrofa commented "Closed in favor of #462. Same change, same author, fixed tests." PR #462 by kyrofa was subsequently merged as commit a983e470b, which prefixes the generated LD_LIBRARY_PATH with ${SNAP_LIBRARY_PATH}${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} in snapcraft/utils.py and updates the corresponding unit/spread test expectations.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Trivial branch that adds the new SNAP_LIBRARY_PATH so that the right paths for opengl will be used.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #460 (mvo5, one-line SNAP_LIBRARY_PATH addition) was closed unmerged by kyrofa in favour of #462, which made the same change plus test fixes and was merged as commit a983e470b.
stealth/space-bunny-alpha — closed superseded PR #460 (add SNAP_LIBRARY_PATH) was closed unmerged by kyrofa in favour of #462, the same change by the same author with test fixes; #462 was merged as commit a983e470b, adding SNAP_LIBRARY_PATH to LD_LIBRARY_PATH (LP #1570945).
stealth/space-bunny-alpha — closed superseded PR #460 (mvo5, one-line SNAP_LIBRARY_PATH addition) was closed unmerged in favour of #462, which kyrofa landed with test fixes as commit a983e470b, resolving LP bug #1570945.
stealth/space-bunny-alpha — closed superseded Superseded by canonical/snapcraft#462, which added SNAP_LIBRARY_PATH to LD_LIBRARY_PATH with test fixes and was merged as commit a983e470b.
qwen/qwen3.6-35b-a3b — — Superseded by PR #462. The SNAP_LIBRARY_PATH addition for OpenGL paths was merged in the successor, which included the requested test fixes and rebase.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #462. The change adding SNAP_LIBRARY_PATH for OpenGL paths was closed after test fixes and a rebase were requested. PR #462 contains the identical update with tests resolved.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#462 (confidence 99%)

    Identical change by the same author, with tests fixed and rebased onto master; merged as commit a983e470b.

  • Likely Fixed By: snapcraft#462 (confidence 95%)

    Merged commit a983e470b adds SNAP_LIBRARY_PATH to the generated LD_LIBRARY_PATH in snapcraft/utils.py, present in the current tree.

Related issues

Issue Project State Summary Similarity
#462 Add SNAP_LIBRARY_PATH to LD_LIBRARY_PATH. snapcraft merged PR #462 by kyrofa merged as commit a983e470b, prefixing the generated LD_LIBRARY_PATH with ${SNAP_LIBRARY_PATH}${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} so snaps pick up host OS snap libraries. Resolves LP bug #1570945.
78%