fix(application): support snap/craft environment variables
Metadata
Current evaluation
Merged after three approvals and passing CI. The PR adds snap/craft environment variable support across two files. Initial spread test failures and merge conflicts from a concurrent PR were resolved before final integration.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after three approvals and passing CI. The PR adds snap/craft environment variable support across two files. Initial spread test failures and merge conflicts from a concurrent PR were resolved before final integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after fixing spread tests and updating commit formatting. Conflicts arose when a related PR merged first, requiring rebasing. The fix adds snap/craft environment variable support with passing tests and coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged PR adding snap/craft environment variable support. Author fixed spread test failures and updated commit naming. Merge conflicts from a related PR were resolved before final integration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3748 parts: define variables and expand them in snapcraft.yaml | snapcraft | merged | Merged after approval and passing CI. Adds global and step-specific SNAPCRAFT_* variables for snapcraft.yaml and lifecycle execution, extending CRAFT_* support. A reviewer requested a spread test rerun for 22.04. | |
| #2897 meta: include environment in hook wrappers | snapcraft | merged | Merged a fix restoring environment variable inclusion for Snapcraft hook wrappers, correcting a regression that limited it to apps. Approved, passed CI, and modified three files. Resolves LP #1824255. | |
| #3645 meta: parse environment variables (CRAFT-835) | snapcraft | merged | Merged into snapcraft/7.0. Implements parsing for the environment dictionary in snapcraft.yaml at the root and app levels. Approved, passed CI and unit tests, and achieved 100% diff coverage. | |
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged after two approvals. The PR updates integration tests to run against the installed snapcraft snap, aligning with user environments. Despite a reported Go runtime address space conflict in CI, the changes were accepted and merged. | |
| #1370 integrations: add the snapcraft Dockerfile | snapcraft | merged | Merged the snapcraft Dockerfile to centralize its source and add a required environment variable for snapcraft 2.31. Approved by one reviewer and passed CI checks. | |
| #5529 fix: remove test artifact workaround | snapcraft | merged | Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files. | |
| #2122 many: introduce variables for part src and build | snapcraft | merged | Merged following approval. Introduces new environment variables and replacements for part src and build directories, resolving LP #1763028. Consolidates SNAPCRAFT_* environment handling into a single location. Approved by one reviewer with passing CI checks. | |
| #4 snap: introduce initial snap packaging (CRAFT-578) | rockcraft | merged | Merged initial snap packaging implementation (CRAFT-578). Approved by one reviewer, passed CI checks, and added 86 lines across three files. | |
| #2793 tests: enable SNAPCRAFT_BUILD_INFO for spread | snapcraft | merged | Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files. | |
| #4601 feat: use craft-application project variables | snapcraft | merged | Merged after three approvals and passing CI. Implements version and grade as craft-application project variables updatable via craftctl. Rebased and test failures resolved prior to merge. |