fix(project): fix core24/devel validation
Metadata
Current evaluation
Merged PR #4608 fixed core24/devel project validation by passing complete input values to the regular validator instead of only fields validated so far.
Resolution: closed resolved
Reason: PR #4608 was merged, and repository history records the fix as commit 3178f807a. It corrects the partial-values validation footgun affecting core24/devel projects.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The regular validator's 'values' parameter contains only the fields that have been validated so far (a bad footgun).
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4608 fixed core24/devel project validation by passing complete input values to the regular validator instead of only fields validated so far. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4608 fixed core24/devel validation by correcting the regular validator's values input, which previously contained only fields validated so far. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for core24/devel validation. Resolved a bug where the validator values parameter incorrectly contained only previously validated fields. Approved by two reviewers, passed CI, and modified two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for core24/devel validation where the regular validator's values parameter incorrectly contained only previously validated fields. Tests passed, coverage was confirmed, and an unrelated spread failure was dismissed. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6451 fix(core22): report invalid projects instead of crashing | snapcraft | closed | PR #6451 proposed validation and error-formatting fixes for invalid core22 projects, including #5613, but was closed unmerged; no resolving commit was found and #5613 remains open. |