fix(project): fix core24/devel validation
Metadata
Current evaluation
Merged fix for core24/devel validation. Resolved a bug where the validator values parameter incorrectly contained only previously validated fields. Approved by two reviewers, passed CI, and modified two files.
Suggested action: —
No scores available.
Issue body
The regular validator's 'values' parameter contains only the fields that have been validated so far (a bad footgun).
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for core24/devel validation. Resolved a bug where the validator values parameter incorrectly contained only previously validated fields. Approved by two reviewers, passed CI, and modified two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for core24/devel validation where the regular validator's values parameter incorrectly contained only previously validated fields. Tests passed, coverage was confirmed, and an unrelated spread failure was dismissed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to fix core24/devel validation. The change resolves a bug where the validator's 'values' parameter incorrectly contained only previously validated fields. Tests and coverage passed, with the author noting an unrelated spread failure. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4557 feat!: fail if we know the project is core24 | snapcraft | merged | Merged a breaking change that fails early for core24 projects. Added core24 spread tests with expected failures and updated CI workflows. Approved by two reviewers and passed all checks. | |
| #4757 fix: set project variables for core24 | snapcraft | merged | Merged a fix setting CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION variables for core24 snaps. Approved by two reviewers, passed CI, and resolved issues #4704 and #4702. | |
| #2417 fix: fix a series of breaking spread tests | charmcraft | merged | Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation. |