← Back to issue list

Kernel plugin: Support lzma/xz-compressed initrd.

View original Github issue

Metadata

Project
snapcraft
Number
#463
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #463 as ac25418f5, adding lzma/xz initrd detection via the magic library and tests for LP bug #1569337.

Resolution: closed resolved

Reason: The pull request was merged into Snapcraft as commit ac25418f5. It replaced file-based initrd detection with the magic library and added coverage for lzma/xz-compressed initrds.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is another attempt at fixing LP: [#1569337](https://bugs.launchpad.net/snapcraft/+bug/1569337) which uses the magic library instead of shelling out to `file`. It also adds some tests.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #463 as ac25418f5, adding lzma/xz initrd detection via the magic library and tests for LP bug #1569337.
stealth/space-bunny-alpha — closed resolved Merged #463 (ac25418f5), adding lzma/xz initrd support via the magic library instead of the file command, with tests for LP bug #1569337.
qwen/qwen3.6-35b-a3b — — Merged to add lzma/xz-compressed initrd support to the kernel plugin. Replaces the file command with the magic library and includes tests. Resolves Launchpad bug 1569337. Approved with minor concerns and merged despite six unresolved review comments.
qwen3.6-35b-a3b-mtp-q6 — — Merged after adding lzma/xz-compressed initrd support to the kernel plugin. Replaced the file command with the magic library and added tests. Resolves Launchpad bug 1569337.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#457 kernel plugin: fix decompressio of lzma initrd (and others) snapcraft closed PR #457 fixing lzma initrd decompression in the kernel plugin was closed unmerged; kyrofa (2016-04-15) closed it in favor of #463, which was merged as commit ac25418f5 adding lzma/xz initrd detection via magic-file sniffing.
81%
#1569337 snapcraft kernel plugin needs to check compression method of the initrd before trying to unpack it snapcraft (launchpad) closed Kernel plugin gained initrd compression detection and LZMA/XZ support instead of assuming gzip; fixed by merged PR canonical/snapcraft#463 (commit ac25418f5).
72%
#1839 kernel plugin: update initrd.img-core path to boot/initrd.img snapcraft merged Merged PR #1839 as commit aaf5e68b1, updating the kernel plugin to use boot/initrd.img instead of initrd.img-core and fixing LP bug #1740882.
70%