← Back to issue list

Kernel plugin: Support lzma/xz-compressed initrd.

View original Github issue

Metadata

Project
snapcraft
Number
#463
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged to add lzma/xz-compressed initrd support to the kernel plugin. Replaces the file command with the magic library and includes tests. Resolves Launchpad bug 1569337. Approved with minor concerns and merged despite six unresolved review comments.

Suggested action:

No scores available.

Issue body

This is another attempt at fixing LP: [#1569337](https://bugs.launchpad.net/snapcraft/+bug/1569337) which uses the magic library instead of shelling out to `file`. It also adds some tests.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to add lzma/xz-compressed initrd support to the kernel plugin. Replaces the file command with the magic library and includes tests. Resolves Launchpad bug 1569337. Approved with minor concerns and merged despite six unresolved review comments.
qwen3.6-35b-a3b-mtp-q6 Merged after adding lzma/xz-compressed initrd support to the kernel plugin. Replaced the file command with the magic library and added tests. Resolves Launchpad bug 1569337.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds lzma/xz-compressed initrd support to the kernel plugin by replacing shell-outs to file with libmagic. Resolves Launchpad bug 1569337 and includes new tests. Approved by maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#457 kernel plugin: fix decompressio of lzma initrd (and others) snapcraft closed Superseded by #463. The pull request was closed to address the lzma initrd decompression fix through an alternative PR.
79%
#6255 Feature/kernel initrd plugin merge snapcraft merged Merged after resolving conflicts and aligning with HEAD. Integrates kernel initrd plugin support, requires PR #6254, approved by two reviewers, and passed CI checks.
75%
#1839 kernel plugin: update initrd.img-core path to boot/initrd.img snapcraft merged Merged an update to the kernel plugin that changes the initrd.img-core path to boot/initrd.img. Resolves Launchpad bug 1740882 across two files.
73%
#6116 feat: kernel|initrd plugins: extend and improve behavior snapcraft merged Merged after review and testing. Extended kernel and initrd plugins by migrating fetch logic, adding Ubuntu release and binary package options, and supporting extra kernel tools. Removed ZFS/DKMS support in favor of documentation. Supersedes #6102.
72%
#1223 kernel plugin: check_config() and check_initrd() support snapcraft merged Merged implementation of check_config() and check_initrd() for the kernel plugin. The update parses .config and initrd files to verify mandatory kernel options and boot code are present. Minor test coverage decrease was accepted.
72%
#476 kernel plugin: iterate over modules to add to initrd snapcraft merged Merged updates to the kernel plugin that iterate over modules for initrd inclusion. Approved by @kyrofa following successful tests. Resolves LP #1572118 with 36 additions and 6 deletions across two files.
72%
#5814 feat(plugins): add kernel and initrd plugins snapcraft merged Merged into a feature branch after simplifying kernel and initrd plugin logic and addressing review feedback. Unrelated spread test failures prompted a temporary merge to prevent staleness, with full integration pending upstream fixes.
71%
#3998 Kernel plugin: multiple fixes snapcraft merged Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks.
71%
#6254 feat(kernel,initrd): extend plugins with new options, stabilize snapcraft merged Merged after approval. Extended the kernel plugin with new options, stabilized the initrd plugin, improved documentation, and added tests. Resolved a temporary Resolute tarball naming divergence. Core CI checks passed.
71%