feat: enable patchelf for core24
Metadata
Current evaluation
Enabled patchelf for core24. Merged after approval from two reviewers and passing CI checks. The change updates six files (+75/-9 lines) with full test coverage on modified code.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Enabled patchelf for core24. Merged after approval from two reviewers and passing CI checks. The change updates six files (+75/-9 lines) with full test coverage on modified code. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the feature enabling patchelf for core24. The change passed lint and test suites, maintained 100% coverage on modified lines, and was successfully integrated into the codebase by maintainer lengau. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the feature to enable patchelf for core24. Passed all checks, achieved 100% coverage on modified lines, and was integrated into the feature/craft-application branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4700 feat: partitions for core24 | snapcraft | merged | Merged feature adding partitions for core24. Approved by two reviewers, the PR modifies 16 files (+461/-26 lines). Codecov flagged 10 lines missing coverage, but the changes were successfully integrated into main. | |
| #4669 fix(core24): use correct libc6 path | snapcraft | merged | Merged a fix updating the core24 libc6 linker path to /usr to accommodate usrmerge. Approved by two reviewers, passed CI, and maintained full test coverage on modified lines. | |
| #3589 snap: correct patch apply for patchelf | snapcraft | merged | Merged a two-line fix correcting patch application for patchelf. Approved by a reviewer, passed CI, and merged to master. An unrelated test failure was noted but disregarded to proceed. | |
| #5486 build: add patchelf to make dependencies | snapcraft | merged | Merged to add patchelf to development environment dependencies, resolving test failures on self-hosted runners. Approved by two reviewers and passed CI checks. | |
| #1873 elf: cleaner patchelf experience | snapcraft | merged | Merged improvements to patchelf handling. The change uses the system patchelf by default, copies files to prevent hard-link conflicts, and provides fallback instructions. Approved by two reviewers and passed CI checks before merging. | |
| #2006 many: use packaging logic to get patchelf | snapcraft | merged | Merged following reviewer approval and CI checks. Refactored patchelf retrieval to use shared packaging logic, aligning its version across snap and deb packages. Modified four files with a net reduction of 24 lines. | |
| #4606 feat(app): support extensions in core24 | snapcraft | merged | Added extension support to core24. Merged after approval by two reviewers, passing all CI checks with 100% coverage on modified lines. The change updated nine files, adding 183 lines and removing 30. | |
| #3588 snap: patch patchelf on riscv64 (CRAFT-566) | snapcraft | merged | Merged to master. Conditionally applies patchelf patches on riscv64 to prevent breaking other architectures. Approved by one reviewer, passed CI, and added 104 lines across three files without impacting test coverage. | |
| #4557 feat!: fail if we know the project is core24 | snapcraft | merged | Merged a breaking change that fails early for core24 projects. Added core24 spread tests with expected failures and updated CI workflows. Approved by two reviewers and passed all checks. |