← Back to issue list

chore: merge feature/components into feature/craft-application

View original Github issue

Metadata

Project
snapcraft
Number
#4654
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4654 as 76e909dea, integrating feature/components into feature/craft-application and adding core22 component support after test fixes.

Resolution: closed resolved

Reason: PR #4654 merged with three approvals and was recorded as commit 76e909dea ("feat: components for core22"). The commit integrated the branches and included fixes to unit and spread tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4654 as 76e909dea, integrating feature/components into feature/craft-application and adding core22 component support after test fixes.
stealth/space-bunny-alpha — closed resolved Merged feature/components into feature/craft-application as 76e909dea (“feat: components for core22”), with unit and spread test fixes.
stealth/space-bunny-alpha — closed resolved Merged feature/components into feature/craft-application as 76e909dea, adding core22 component support after unit and spread-test fixes.
stealth/space-bunny-alpha — closed resolved Merged as commit 76e909dea "feat: components for core22": folded the feature/components work into feature/craft-application (+1549/-68, 28 files), fixing unit/spread test expectations for the new top-level prime partitions after craft-parts#684.
stealth/space-bunny-alpha — closed resolved Merged as commit 76e909dea (“feat: components for core22”), adding components to the craft-application branch after fixes to unit and spread tests.
qwen/qwen3.6-35b-a3b — — Merged feature/components into feature/craft-application following three reviewer approvals. The update modified 28 files with over 1500 additions and 68 deletions. Test and CI issues were resolved during review before final integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged feature/components into feature/craft-application. Resolved CI failures, version check regressions, and spread test errors during review. Cleaned up redundant tests and fixed organizing logic prior to merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4644 (confidence 99%)

    The tracking issue for merging feature/components into feature/craft-application was resolved by this PR and commit.

  • Related To: canonical/craft-parts#684 (confidence 90%)

    Review discussion cited its namespaced-partition implementation as relevant to component test expectations.

Related issues

Issue Project State Summary Similarity
#4585 chore: merge main into feature/craft-application snapcraft merged Merged main into feature/craft-application via PR #4585 after two approvals; the sync changed 17 files (+345/-93) with no unresolved review comments.
84%
#4644 Merge `feature/components` into `feature/craft-application` snapcraft closed Tracking issue to merge feature/components into feature/craft-application. Done via merged PR #4654, commit 76e909dea ("feat: components for core22"); PR #4648 was closed unmerged in its favour.
82%
#4633 chore: merge main into feature/craft-application snapcraft merged Routine chore PR merged into feature/craft-application as commit 029100cc4, syncing main after 3 approvals (+58/-44, 23 files); Codecov reported 100% coverage of modified lines, 89.14% project coverage.
82%
#4581 chore(merge): 'main' into 'feature/components' snapcraft merged Merged PR #4581 brought main into feature/components, updating the components snap with core24 support in revision 10646 and fixing #4576.
82%
#4579 chore(merge): 'main' into 'feature/components' snapcraft closed PR #4579 merged main into feature/components, bringing the core24 provider fix into the components build; components snap revision 10646 was verified for #4576.
81%
#4549 chore(merge): rebase on origin/main snapcraft merged Merged PR #4549 into feature/craft-application, syncing it with origin/main as the first branch-integration step; the feature was later merged into main by #4560.
80%
#918 chore(merge): feature/pro-sources into main craft-providers merged Merged feature/pro-sources into main via #918 (commit b56ff14), completing CRAFT-5012 with all CI checks passing and 1,594 additions across 9 files.
80%
#923 chore(merge): 2.1.4 into main craft-parts merged Merged craft-parts 2.1.4 back into main via PR #923 (merge commit 92075f67).
78%
#1397 chore: merge main to craft-application feature branch charmcraft merged Merged main into the craft-application feature branch, approved by two reviewers; the merge manually set craft-application to 1.1.0. The feature was completed in #1399.
78%
#1356 chore: merge main into craft-application branch charmcraft merged Merged #1356 into the craft-application branch, synchronizing main across 13 files (+82/-74); the broader migration continued in #1399 (3ba803d1).
77%