← Back to issue list

fix: set project variables for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4757
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4757 as commit 27957515c, fixing core24 project-variable expansion and closing #4704/#4702; CRAFT_* setup was linked to canonical/craft-application#320.

Resolution: closed resolved

Reason: PR #4757 was merged as commit 27957515c. The change corrected core24 project-variable handling, resolving linked issues #4704 and #4702.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Set project variables for core24 snaps. `CRAFT_PROJECT_NAME` and `CRAFT_PROJECT_VERSION` are not set, see https://github.com/canonical/craft-application/issues/320 for details. Fixes #4704 Fixes #4702 (CRAFT-2657) (CRAFT-2655)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4757 as commit 27957515c, fixing core24 project-variable expansion and closing #4704/#4702; CRAFT_* setup was linked to canonical/craft-application#320.
stealth/space-bunny-alpha — closed resolved Merged #4757 fixes core24 project-variable expansion by setting CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION, resolving #4704 and #4702.
qwen/qwen3.6-35b-a3b — — Merged a fix setting CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION variables for core24 snaps. Approved by two reviewers, passed CI, and resolved issues #4704 and #4702.
qwen3.6-35b-a3b-mtp-q6 — — Merged to set CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION for core24 snaps, resolving issues #4704 and #4702.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4704 (confidence 100%)

    Explicitly listed as fixed by PR #4757.

  • Related To: snapcraft#4702 (confidence 100%)

    Explicitly listed as fixed by PR #4757.

  • Related To: canonical/craft-application#320 (confidence 95%)

    PR body cites this issue for the underlying missing CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION behavior.

Related issues

Issue Project State Summary Similarity
#4704 Some variables aren't properly set snapcraft closed Fixed core24 architecture/project environment-variable setup by merged PR #4757 (commit 27957515c); remaining CRAFT_PROJECT_NAME/VERSION interpolation stayed tracked in craft-application#320.
81%
#4741 fix(env): set global environment variables for craft-app snapcraft closed Closed unmerged in favor of #4757, which added core24 project-variable expansion in commit 27957515c.
76%
#4702 [craft-application/core24] $SNAPCRAFT_PROJECT_VERSION and other fields not replaced snapcraft closed Core24 project-variable replacement was fixed by merged PR #4757 (commit 27957515c). Remaining CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION handling was tracked in craft-application#320.
75%
#336 fix global environment expansion rockcraft merged PR #336 (commit 42627c1a) by cjdcordeiro merged, fixing missing global variable expansion so CRAFT_PROJECT_VERSION and other CRAFT_ vars are set before parts lifecycle; project loading now returns YAML for unmarshal.
74%
#4771 Snapcraft does not evaluate project variables added by extensions in core24 snapcraft closed Fixed by merged PR #4779 (commit 3e3428ec1), upgrading craft-application to 2.6.3 so extension-added project variables are evaluated in core24.
72%
#4770 Wrong arch being used in core24 project variables snapcraft closed Fixed by merged PR #4779 (commit 3e3428ec1): craft-application 2.6.3 supplied the build-for architecture fix, with regression coverage added.
72%