← Back to issue list

fix: set project variables for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4757
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged a fix setting CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION variables for core24 snaps. Approved by two reviewers, passed CI, and resolved issues #4704 and #4702.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Set project variables for core24 snaps. `CRAFT_PROJECT_NAME` and `CRAFT_PROJECT_VERSION` are not set, see https://github.com/canonical/craft-application/issues/320 for details. Fixes #4704 Fixes #4702 (CRAFT-2657) (CRAFT-2655)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix setting CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION variables for core24 snaps. Approved by two reviewers, passed CI, and resolved issues #4704 and #4702.
qwen3.6-35b-a3b-mtp-q6 Merged to set CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION for core24 snaps, resolving issues #4704 and #4702.
qwen3.6-35b-a3b-mtp-q6 Merged a fix initializing CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION for core24 snaps, resolving issues #4704 and #4702. The change ensures proper project variable assignment.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4702 [craft-application/core24] $SNAPCRAFT_PROJECT_VERSION and other fields not replaced snapcraft closed Resolved via PR #4757. The core24 variable replacement failure was fixed, though CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION remain unevaluated and are tracked separately in craft-application#320.
76%
#4704 Some variables aren't properly set snapcraft closed Fixed via PR #4757 by correctly setting architecture variables for core24 cross-architecture builds. CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION remain unprocessed and are tracked separately in craft-application issue #320.
73%
#4608 fix(project): fix core24/devel validation snapcraft merged Merged fix for core24/devel validation. Resolved a bug where the validator values parameter incorrectly contained only previously validated fields. Approved by two reviewers, passed CI, and modified two files.
72%
#767 build(snap): update snap to core24 rockcraft merged Merged the snap build update to core24, resolving issue #750. Approved by two reviewers, the change modified seven files. Changelog updates are handled separately during pre-release.
72%
#4594 fix(lifecycle): install 'core24' snap snapcraft merged Merged a lifecycle fix to install the core24 snap, ensuring proper package cutoff functionality based on the project base. Approved by two reviewers, passed CI, and modified 9 files (+97/-9 lines).
70%
#5499 fix: evaluate variables in project file snapcraft merged Merged fix for project variables not evaluating in project files, caused by the craft-application 5 rebase. Includes a core22 spread test and changelog update. Resolves #5491.
70%