fix: use local keys for package-repos in core24
Metadata
Current evaluation
Merged PR #4758 (commit b8ff64b89) into hotfix/8.2, making core24 package-repositories use local signing keys; fixes issue #4743 where local key assets were ignored.
Resolution: closed resolved
Reason: PR #4758 was approved by 2 maintainer reviewers and merged as commit b8ff64b89, adding 47 lines across 3 files so core24 package repositories resolve signing keys locally; Codecov confirmed all changed lines are test-covered.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4758 (commit b8ff64b89) into hotfix/8.2, making core24 package-repositories use local signing keys; fixes issue #4743 where local key assets were ignored. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4758 as commit b8ff64b89, making core24 package repositories use local signing keys across three files, with all modified lines covered by tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4758 updates core24 package-repository configuration to use local keys across three files, following two approvals with all modified lines covered by tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI. Updates package repository configuration to use local keys for core24 across three files (+47 lines). All modified code is covered by tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to use local keys for package-repos in core24. The change passed linting and test suites, with Codecov confirming full coverage of modified lines. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4743
(confidence 93%)
Issue #4743 reported local key assets not being used for package-repositories on core24; it was closed by this PR
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4743 Local key assets are not used in package-repositories for core24 | snapcraft | closed | Fixed in merged PR #4758 (commit b8ff64b89), enabling core24 package repositories to use local signing keys instead of only a keyserver. | |
| #4740 `package-repositories` fail with the core24 base due to missing packages | snapcraft | closed | Fixed in merged PR #4754 (commit 712626448) and released in Snapcraft 8.2.1: core24 remote builds now install GPG/dirmngr before configuring package repositories. | |
| #4754 fix: install gpg and dirmngr in core24 builds | snapcraft | merged | Merged in Snapcraft 8.2.1 via #4754 (commit 712626448), installing gpg and dirmngr in core24 remote builds before using package-repositories. |