fix: use local keys for package-repos in core24
Metadata
Current evaluation
Merged following two approvals and passing CI. Updates package repository configuration to use local keys for core24 across three files (+47 lines). All modified code is covered by tests.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI. Updates package repository configuration to use local keys for core24 across three files (+47 lines). All modified code is covered by tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to use local keys for package-repos in core24. The change passed linting and test suites, with Codecov confirming full coverage of modified lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to use local keys for package-repos in core24. The change passed all linting and test suites, with Codecov confirming full coverage of modified lines. Successfully integrated into the codebase. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4743 Local key assets are not used in package-repositories for core24 | snapcraft | closed | Resolved the bug where local key assets were ignored for core24 package-repositories. Fixed via pull request #4758 and closed. | |
| #4754 fix: install gpg and dirmngr in core24 builds | snapcraft | merged | Merged to install gpg and dirmngr in core24 builds, fixing Launchpad dependency errors. The change replicates core22 behavior after bundling failed due to hardcoded paths. Approved by reviewers and passed CI. | |
| #317 feat: support local keys in package-repositories | craft-application | merged | Merged PR implementing local key support for package repositories. Introduces an overridable method for applications providing local assets, such as Snapcraft. Approved by two reviewers, passed CI, and applied across five files (+54/-12 lines). | |
| #755 fix: add list of ignore packages in core24 | craft-parts | merged | Merged. Updated the ignored packages list for core24 by adapting the core22 baseline to match core24's current package contents. Approved by two reviewers and passed CI checks. | |
| #4763 tests: remove core24 snap workarounds (#4761) | snapcraft | merged | Merged into main after two approvals and passing CI. The change cherry-picks test updates to remove core24 snap workarounds, resolving CI failures by deleting 22 lines of legacy code in a single file. |