← Back to issue list

fix(remote): use launchpad credentials from legacy location

View original Github issue

Metadata

Project
snapcraft
Number
#4762
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; snapcraft#4892 later implemented the legacy Launchpad credential fallback in commit c1c70a249.

Resolution: closed superseded

Reason: The author declined this PR after prior migration notice and a testing period. Snapcraft#4892 superseded it by merging the equivalent fallback for both remote builders in c1c70a249.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- If launchpad credentials do not exist in the new location (`$XDG_DATA_HOME/snapcraft/launchpad-credentials`) but exist in the legacy location (`$XDG_DATA_HOME/snapcraft/provider/launchpad/credentials`), then emit a deprecation warning and copy the credentials to the new location.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; snapcraft#4892 later implemented the legacy Launchpad credential fallback in commit c1c70a249.
stealth/space-bunny-alpha — closed superseded Closed unmerged; the legacy Launchpad credential fallback was later merged in snapcraft#4892 via commit c1c70a249.
stealth/space-bunny-alpha — closed superseded Closed unmerged; equivalent legacy Launchpad credential fallback was later merged in canonical/snapcraft#4892 via commit c1c70a249, fixing #4889.
stealth/space-bunny-alpha — closed superseded Closed unmerged; PR #4892 later implemented the same legacy Launchpad credential fallback in commit c1c70a249.
qwen/qwen3.6-35b-a3b — — Abandoned. The maintainer closed the pull request without merging, declining to implement legacy launchpad credential migration. Existing changelog deprecation notices and a call for testing were deemed sufficient.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned by the maintainer. The credential migration and deprecation warning were deemed unnecessary after prior changelog notices. The pull request was closed without implementation.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#4892 (confidence 99%)

    Merged replacement implementing the legacy Launchpad credential fallback.

  • Related To: snapcraft#4889 (confidence 95%)

    The credential compatibility issue resolved by replacement PR #4892.

Related issues

Issue Project State Summary Similarity
#4892 fix(remotebuild): use legacy launchpad credentials if they exist snapcraft merged Merged in snapcraft#4892 as c1c70a249, adding legacy Launchpad credential fallback, build-for: all support, and expanded remote-build tests; fixes #4889.
88%
#4889 Use launchpad credentials from the new location and fallback to the legacy location snapcraft closed Fixed in canonical/snapcraft#4892 (c1c70a249): both remote builders now fall back to legacy Launchpad credentials and emit a deprecation warning.
84%
#1827679 Update remote build login when Launchpad infrastructure is ready snapcraft (launchpad) closed Remote builds now authenticate with Launchpad personal access tokens instead of SSH keys via snapcraft#4270 (commit 7c80a055b).
73%
#4708 feat(remote): get a user-provided Launchpad project snapcraft merged Merged PR #4708 in commit 6ff73a1fc, adding retrieval of a user-provided Launchpad project for Snapcraft remote builds.
71%