← Back to issue list

feat: allow packing a directory

View original Github issue

Metadata

Project
snapcraft
Number
#4794
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4794 (commit 48483c4e3) restores `snapcraft pack <directory>`, fixing the 8.2 regression where the directory argument was ignored when locating snapcraft.yaml; closes issue #4769 (CRAFT-2861).

Resolution: closed resolved

Reason: PR #4794 was merged as commit 48483c4e3 ("fix: allow packing a directory"), changing7 files (+121/-7) and approved by two reviewers, resolving the 8.2 regression reported in issue #4769. Per the linked issue, the fix shipped in Snapcraft 8.2.6 and was confirmed by the reporter.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- This fixes a regression in snapcraft 8.2 where `snapcraft pack <directory>` stopped working. Fixes #4769 (CRAFT-2861)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4794 (commit 48483c4e3) restores `snapcraft pack <directory>`, fixing the 8.2 regression where the directory argument was ignored when locating snapcraft.yaml; closes issue #4769 (CRAFT-2861).
stealth/space-bunny-alpha — closed resolved PR #4794 (commit 48483c4e3) merged, restoring `snapcraft pack <directory>` broken in 8.2.1 and fixing issue #4769; fix shipped in Snapcraft 8.2.6 (CRAFT-2861).
stealth/space-bunny-alpha — closed resolved Merged PR #4794 (commit 48483c4e3), restoring `snapcraft pack <directory>` and fixing the 8.2 regression in 8.2.6; resolved #4769.
qwen/qwen3.6-35b-a3b — — Merged to restore snapcraft pack directory functionality after a snapcraft 8.2 regression. Approved by two reviewers, passed CI, and resolved issue #4769.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for a snapcraft 8.2 regression that broke snapcraft pack directory. The maintainer force-pushed to remove extraneous commits before merging, resolving issue #4769 and CRAFT-2861.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4769 (confidence 98%)

    Issue #4769 ('snapcraft 8.2.1: `snapcraft pack` not respecting <directory> arg') is the regression this PR fixes and closes; released in 8.2.6.

  • Related To: canonical/snapcraft#5083 (confidence 45%)

    Later, related failure where .snapcraft.yaml is not picked up as a project file (fixed separately for core24 in 8.9 by PR #5349), not by this PR.

Related issues

Issue Project State Summary Similarity
#4769 snapcraft 8.2.1: `snapcraft pack` not respecting `<directory>` arg to find `snapcraft.yaml` snapcraft closed Fixed in Snapcraft 8.2.6 by PR #4794 (commit 48483c4e3), restoring project-file lookup for snapcraft pack <directory>; the reporter confirmed the fix.
80%
#55 feat: support 'pack' command craft-actions merged Merged PR #55 as commit abf3fbd, adding version-aware `snapcraft pack` support while retaining legacy `snapcraft` calls for older versions. Fixes #53.
77%
#45 feat: create new snapcraft-pack action craft-actions merged Merged as commit 8756708, adding a snapcraft/pack action modeled on charmcraft/pack, with shared common/ workflows, working `path` input, and snap/ dir added to the cache key. All CI checks passed; docs followed in #46.
73%
#4506 feat: pack components snapcraft merged Merged PR #4506 added component packaging to snap pack, placing auto-named .comp files in the requested output directory and fixing #4467.
72%
#1782774 Add packing API snapcraft (launchpad) closed Packing API work was resolved by LP #1782780 and canonical/snapcraft PR #2225, merged as commit 16ef9d3cf.
71%