← Back to issue list

Don't clean target before extracting npm

View original Github issue

Metadata

Project
snapcraft
Number
#489
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #489 as commit 5d2bca7e7, removing target cleanup before npm extraction so existing target contents are preserved.

Resolution: closed resolved

Reason: PR #489 was merged as commit 5d2bca7e7. The change stops Snapcraft from cleaning the target directory before extracting npm content.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #489 as commit 5d2bca7e7, removing target cleanup before npm extraction so existing target contents are preserved.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#489 (commit 5d2bca7e7), preserving existing target contents by removing cleanup before npm extraction.
stealth/space-bunny-alpha — closed resolved Merged PR #489 as commit 5d2bca7e7, preserving existing npm extraction targets by removing the pre-extraction cleanup.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#489, removing target cleanup before npm extraction so existing contents are preserved.
qwen/qwen3.6-35b-a3b — — Merged a change preventing target directory cleanup before npm extraction. Approved by @kyrofa after clarifying behavior. The update modifies two files with a three-line adjustment to preserve target contents during npm extraction.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix preventing target directory cleanup before npm extraction. Maintainer sergiusens submitted the patch, which kyrofa approved after clarifying the intended behavior. Successfully integrated.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.