fix: use correct types for validation set models
Metadata
Current evaluation
Merged #4928 switched validation-set models to Pydantic and corrected API types, fixing #4909. The change also made the boilerplate validation set valid and shipped in Snapcraft 8.3.2.
Resolution: closed resolved
Reason: PR #4928 was approved and merged, explicitly fixing #4909 by using the correct data types for edit-validation-sets API calls. The fix was released in Snapcraft 8.3.2.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
1. Uses the correct data types for API calls (#4909)
2. Switch to pydantic models
- when editing the validation set, errors are caught immediately and presented to the user to resolve rather than uploading to the store and waiting for the store to validate the data
4. Make the boilerplate validation set valid (previously, using the boilerplate would raise an error)
I'll be using this code as groundwork for #4917.
Fixes #4909
(CRAFT-3103)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4928 switched validation-set models to Pydantic and corrected API types, fixing #4909. The change also made the boilerplate validation set valid and shipped in Snapcraft 8.3.2. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4928 switched validation-set models to Pydantic with correct API types, fixed #4909, and corrected the boilerplate set; released in Snapcraft 8.3.2. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4928, switching validation-set models to Pydantic and correct API types; it fixed #4909, corrected the boilerplate validation set, and was released in Snapcraft 8.3.2. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and reporter testing. Replaced validation set models with Pydantic types for immediate error handling, corrected API data types, and fixed boilerplate validation sets. Resolves #4909. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix correcting validation set model types and implementing Pydantic for immediate error handling. Resolves #4909, fixes boilerplate validation errors, and was verified working by the original reporter. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft#4909
(confidence 100%)
The PR explicitly states that it fixes the incorrect revision type reported in #4909.
-
Related To:
snapcraft#4917
(confidence 95%)
The author identified #4928 as groundwork for the registry-set commands proposed in #4917.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4909 Fix revision type in `edit-validation-sets` | snapcraft | closed | Fixed by merged PR #4928 (commit feed34eba), correcting validation-set API field types. Released in Snapcraft 8.3.2 to latest/stable and 8.x/stable. |