← Back to issue list

Forward proxy variables into core24 build environments

View original Github issue

Metadata

Project
snapcraft
Number
#4943
Type
issue
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Proxy forwarding for core24 builds landed in merged PR #4973 (commit 28da12515): Provider.setup() now calls super().setup(), with regression tests and a craft-application 4.1.0 bump.

Resolution: closed resolved

Reason: Maintainer mr-cal closed the issue after PR #4973 was merged as commit 28da12515, which calls ProviderService.setup() in snapcraft/services/provider.py to forward http_proxy, https_proxy and no_proxy into core24 build environments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Call [`craft_application.services.ProviderService.setup()`](https://github.com/canonical/craft-application/blob/445d5146e20ca6157c59a15112d8f81ac4230203/craft_application/services/provider.py#L90) to forward `http_proxy`, `https_proxy`, and `no_proxy` into core24 build environments. ```diff diff --git a/snapcraft/services/provider.py b/snapcraft/services/provider.py index 2ed2b590..e28b730c 100644 @@ -26,6 +26,12 @@ class Provider(ProviderService): @overrides def setup(self) -> None: + """Snapcraft-specific setup.""" + super().setup() + if build_info := os.getenv("SNAPCRAFT_BUILD_INFO"): self.environment["SNAPCRAFT_BUILD_INFO"] = build_info if image_info := os.getenv("SNAPCRAFT_IMAGE_INFO"): ``` ### Why it needs to get done - To forward proxy variables from the host into the build environment - Parity with core22

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Proxy forwarding for core24 builds landed in merged PR #4973 (commit 28da12515): Provider.setup() now calls super().setup(), with regression tests and a craft-application 4.1.0 bump.
stealth/space-bunny-alpha — closed resolved Proxy variables are now forwarded into core24 build environments by merged PR #4973 (commit 28da12515), restoring parity with core22.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #4973 (commit 28da12515): Provider.setup() now calls super().setup() to forward http_proxy/https_proxy/no_proxy into core24 builds, with a craft-application bump to 4.1.0.
stealth/space-bunny-alpha — closed resolved Fixed by PR #4973 (commit 28da12515), which calls super().setup() in snapcraft/services/provider.py so ProviderService forwards http_proxy/https_proxy/no_proxy into core24 build environments, with regression tests.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #4973 (commit 28da12515), which calls ProviderService.setup() to forward http_proxy/https_proxy/no_proxy into core24 build environments and bumps craft-application to 4.1.0.
stealth/space-bunny-alpha — closed resolved Proxy forwarding for core24 builds was completed in merged PR #4973 (commit 28da12515), with regression coverage and a craft-application 4.1.0 update.
stealth/space-bunny-alpha — closed resolved Proxy forwarding for core24 build environments was added by merged PR #4973 at commit 28da12515, with regression coverage and a craft-application 4.1.0 bump.
qwen/qwen3.6-35b-a3b — — Forwarded http_proxy, https_proxy, and no_proxy variables into core24 build environments. Resolved by merging pull request #4973 into the snapcraft repository.
qwen/qwen3.6-35b-a3b — — Resolved via PR #4973. The fix calls super().setup() in snapcraft/services/provider.py to forward http_proxy, https_proxy, and no_proxy variables into core24 build environments, matching core22 behavior.
qwen/qwen3.6-35b-a3b — — Resolved by merging PR #4973. The fix calls super().setup() in the Provider service to forward http_proxy, https_proxy, and no_proxy into core24 build environments, inheriting behavior from craft_application and ensuring parity with core22.
qwen3.6-35b-a3b-mtp-q6 — — Resolved via merged pull request #4973. The provider service now calls super().setup() to forward http_proxy, https_proxy, and no_proxy into core24 build environments, matching core22 behavior.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#4973 (confidence 97%)

    Merged PR 'fix(provider): forward proxy variables to core24 build environments' (commit 28da12515); maintainer explicitly cited it as the completion of this issue.

  • Related To: craft-application#N (confidence 40%)

    Base behaviour lives in craft-application's ProviderService.setup(); the fix also bumped craft-application to 4.1.0.

Related issues

Issue Project State Summary Similarity
#4973 fix(provider): forward proxy variables to core24 build environments snapcraft merged Merged PR #4973 in commit 28da12515, forwarding proxy variables into core24 builds, adding regression coverage, and bumping craft-application to 4.1.0.
86%
#3906 providers: pass http-proxy and https-proxy to craft-providers snapcraft merged Merged as commit 716a0474 (#3906): forwards http_proxy and https_proxy to craft-providers so core22 build instances honour proxies. Follow-up to #3884 (CRAFT-1334).
71%