← Back to issue list

chore(revert): add content interfaces for qt-common-themes

View original Github issue

Metadata

Project
snapcraft
Number
#5013
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged hotfix #5013 (ec1cc0a5b), temporarily reverting #4884 on hotfix/8.4 to remove qt-common-themes content interfaces and unblock Snapcraft 8.4.

Resolution: closed resolved

Reason: PR #5013 was approved and merged as commit ec1cc0a5b. Its revert removed the interfaces added by #4884 from the 8.4 release branch, while leaving that original change on main.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- This is a temporary revert of #4884 for `hotfix/8.4` to allow releasing snapcraft 8.4. See the discussion in #4884 and [this forum post](https://forum.snapcraft.io/t/kde-global-auto-connect-qt-common-themes/40878) for context.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged hotfix #5013 (ec1cc0a5b), temporarily reverting #4884 on hotfix/8.4 to remove qt-common-themes content interfaces and unblock Snapcraft 8.4.
stealth/space-bunny-alpha — closed superseded Merged a temporary hotfix/8.4 revert of #4884, removing qt-common-themes content interfaces to unblock the Snapcraft 8.4 release.
qwen/qwen3.6-35b-a3b — — Merged a temporary revert of PR #4884 to unblock the snapcraft 8.4 hotfix release. Approved by two reviewers and passing CI, the change removes 107 lines across two files to resolve qt-common-themes content interface issues.
qwen3.6-35b-a3b-mtp-q6 — — Merged as a temporary revert of PR #4884 to unblock the snapcraft 8.4 hotfix release. The qt-common-themes content interfaces were removed pending further review.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4884 (confidence 100%)

    The qt-common-themes interface change merged in fb1834ce8 that #5013 temporarily reverted for the 8.4 hotfix.

Related issues

Issue Project State Summary Similarity
#5429 chore(merge): 8.8.1 into main snapcraft merged Merged hotfix/8.8 into main for Snapcraft 8.8.1 via PR #5429 (commit c74b9716b), with reviewer approval and no unresolved comments.
74%
#4949 chore: cherry-pick fixes to hotfix/8.3 snapcraft merged Merged #4949 into hotfix/8.3, adding two fixes and two CI test updates for Snapcraft 8.3.2; #4953 later merged the release into main (3cdb859f7).
73%
#4535 chore: 8.0.2 hotfixes snapcraft merged Merged as commit bbf8ae08f, delivering the Snapcraft 8.0.2 hotfix changes.
73%
#4574 chore: merge 8.0.3 hotfix into main snapcraft merged Merged the Snapcraft 8.0.3 hotfix branch into main via PR #4574 at commit 5bf03c2ea, consolidating maintenance changes across 11 files.
72%
#4786 chore: merge hotfix 8.2 into main snapcraft merged Merged hotfix/8.2 into main via PR #4786 at commit b3900587b, integrating the Snapcraft 8.2 maintenance changes.
71%
#5747 chore(merge): hotfix/8.11 into main snapcraft merged Merged hotfix/8.11 into main via commit 3005d50aa (#5747), preparing Snapcraft 8.12 after approval; two integration-test jobs remained failing.
71%
#5183 chore(merge): 8.5.1 into main snapcraft merged Merged Snapcraft 8.5.1 into main via #5183 (merge commit bfb63fa79), after approval by two reviewers.
70%
#4824 chore: merge 8.2.9 hotfixes snapcraft merged Merged the Snapcraft 8.2.9 hotfixes in commit c0e3aaac7, fixing KDE Neon 6 web-process support and exposing libplas/liblapack from kf6 snaps.
70%