Reject plug/slot definitions at part level
Metadata
Current evaluation
PR #503 (zyga) removing misleading part-level plugs/slots schema entries was closed unmerged by sergiusens on 2016-05-24 in favour of #514, which added real validation rejecting plugs/slots in parts.
Resolution: closed superseded
Reason: Maintainer sergiusens closed it in favour of snapcraft#514 after requesting a regression test in snapcraft.test_yaml. #514 was merged as commit 6fabd20bcc, which instead fails validation when plugs or slots are declared at part level (LP bug #1581166).
Evaluated by: mr-cal-bot
No scores available.
Issue body
This patch removes incorrect schema entries that allow arbitrary plug
and slot definitions at a part level. Those definitions are ignored by
snapcraft but can cause potential confusion for users that read the
schema.
Fixes: https://bugs.launchpad.net/snapcraft/+bug/1581166
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #503 (zyga) removing misleading part-level plugs/slots schema entries was closed unmerged by sergiusens on 2016-05-24 in favour of #514, which added real validation rejecting plugs/slots in parts. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of canonical/snapcraft#514, which added validation and regression tests rejecting part-level plugs and slots. Merged as commit 6fabd20bc. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Reviewers requested formatting and a regression test, but updates were not provided. The PR was superseded by #514, which rejects plug/slot definitions at the part level. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. Reviewers requested commit formatting and a regression test, but no changes were made. The PR was superseded by #514, which addressed the schema fix for rejecting plug/slot definitions at the part level. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#514
(confidence 97%)
Superseding PR, merged as commit 6fabd20bcc, adds validation rejecting part-level plugs/slots plus the requested unit test.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1581166 unused and potentially confusing support for plugs/slots at a part level in the snapcraft.yaml schema | snapcraft (launchpad) | closed | Snapcraft 2.9 now rejects plugs and slots declared at the part level via merged PR canonical/snapcraft#514 (6fabd20bc); the fix passed SRU verification. | |
| #514 Fail validation if plugs or slots are declared at the part level | snapcraft | merged | PR #514 was merged as commit 6fabd20bc, adding validation that rejects plugs or slots declared inside parts. |